Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 11827007: Couple of tweaks for tables: (Closed)

Created:
7 years, 11 months ago by sky
Modified:
7 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Couple of tweaks for tables: . Expose TableHeader::kHorizontalPadding so that it can be used in calculating preferred width of a column. . Make TableHeader::OnMousePressed return false if not the left mouse button. This lets context menus on an ancestor work. . Exposes couple of methods on TableView used by TaskManager. . Fixes sizes in TableView. . Turns on grouping in table example. BUG=none TEST=none R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175912

Patch Set 1 #

Patch Set 2 : Update comment #

Total comments: 1

Patch Set 3 : Remove views:: #

Patch Set 4 : Add #ifdef for SetGrouper in example #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -14 lines) Patch
M ui/views/controls/table/table_header.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_header.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M ui/views/controls/table/table_view_views.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_view_views.cc View 4 chunks +25 lines, -8 lines 0 comments Download
M ui/views/examples/table_example.h View 1 2 3 chunks +10 lines, -4 lines 0 comments Download
M ui/views/examples/table_example.cc View 1 2 3 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sky
7 years, 11 months ago (2013-01-08 22:44:40 UTC) #1
tfarina
On Tue, Jan 8, 2013 at 8:44 PM, <sky@chromium.org> wrote: > Reviewers: sadrul, > > ...
7 years, 11 months ago (2013-01-08 23:00:19 UTC) #2
tfarina
https://codereview.chromium.org/11827007/diff/1007/ui/views/examples/table_example.h File ui/views/examples/table_example.h (right): https://codereview.chromium.org/11827007/diff/1007/ui/views/examples/table_example.h#newcode34 ui/views/examples/table_example.h:34: public views::TableGrouper, nit: you shouldn't need views:: here, as ...
7 years, 11 months ago (2013-01-08 23:01:24 UTC) #3
sky
nits fixed
7 years, 11 months ago (2013-01-08 23:17:15 UTC) #4
sadrul
LGTM
7 years, 11 months ago (2013-01-09 17:52:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11827007/5001
7 years, 11 months ago (2013-01-09 17:58:14 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-09 18:54:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11827007/10002
7 years, 11 months ago (2013-01-09 19:00:18 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 23:13:39 UTC) #9
Message was sent while issue was closed.
Change committed as 175912

Powered by Google App Engine
This is Rietveld 408576698