Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 11827002: Add a command-line flag to disable canvas antialiasing. This will be used to characterize performa… (Closed)

Created:
7 years, 11 months ago by Stephen White
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add a command-line flag to disable canvas antialiasing. This will be used to characterize performance issues on Android. BUG=168671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175784

Patch Set 1 #

Patch Set 2 : Flip the chrome side code to use _disabled instead of _enabled. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Stephen White
PTAL. Thanks!
7 years, 11 months ago (2013-01-08 21:18:10 UTC) #1
jamesr
The enable/disabled inversions and flips here are a bit hard to follow. The normal state ...
7 years, 11 months ago (2013-01-08 21:24:47 UTC) #2
Stephen White
On 2013/01/08 21:24:47, jamesr wrote: > The enable/disabled inversions and flips here are a bit ...
7 years, 11 months ago (2013-01-08 21:34:39 UTC) #3
jamesr
lgtm
7 years, 11 months ago (2013-01-08 21:43:29 UTC) #4
Stephen White
+avi for OWNERS (if I'm reading the OWNERS file correctly).
7 years, 11 months ago (2013-01-08 22:05:21 UTC) #5
Avi (use Gerrit)
lgtm
7 years, 11 months ago (2013-01-08 22:31:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/11827002/5001
7 years, 11 months ago (2013-01-08 22:41:11 UTC) #7
darin (slow to review)
LGTM
7 years, 11 months ago (2013-01-08 23:25:27 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) content_browsertests
7 years, 11 months ago (2013-01-09 04:41:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/11827002/5001
7 years, 11 months ago (2013-01-09 05:11:44 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 12:15:45 UTC) #11
Message was sent while issue was closed.
Change committed as 175784

Powered by Google App Engine
This is Rietveld 408576698