Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: ppapi/api/dev/pp_video_dev.idl

Issue 11826064: Enforce non-negative BitstreamBuffer id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Documented the wrapping at 30 bits. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/filters/gpu_video_decoder.cc ('k') | ppapi/c/dev/pp_video_dev.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 * Use of this source code is governed by a BSD-style license that can be 2 * Use of this source code is governed by a BSD-style license that can be
3 * found in the LICENSE file. 3 * found in the LICENSE file.
4 */ 4 */
5 5
6 /** 6 /**
7 * NOTE: these must be kept in sync with the versions in media/! 7 * NOTE: these must be kept in sync with the versions in media/!
8 */ 8 */
9 9
10 10
(...skipping 22 matching lines...) Expand all
33 PP_VIDEODECODER_H264PROFILE_MULTIVIEWHIGH = 11, 33 PP_VIDEODECODER_H264PROFILE_MULTIVIEWHIGH = 11,
34 PP_VIDEODECODER_VP8PROFILE_MAIN = 12 34 PP_VIDEODECODER_VP8PROFILE_MAIN = 12
35 }; 35 };
36 36
37 /** 37 /**
38 * The data structure for video bitstream buffer. 38 * The data structure for video bitstream buffer.
39 */ 39 */
40 [assert_size(12)] 40 [assert_size(12)]
41 struct PP_VideoBitstreamBuffer_Dev { 41 struct PP_VideoBitstreamBuffer_Dev {
42 /** 42 /**
43 * Client-specified identifier for the bitstream buffer. 43 * Client-specified identifier for the bitstream buffer. Valid values are
44 * non-negative.
44 */ 45 */
45 int32_t id; 46 int32_t id;
46 47
47 /** 48 /**
48 * Buffer to hold the bitstream data. Should be allocated using the 49 * Buffer to hold the bitstream data. Should be allocated using the
49 * PPB_Buffer interface for consistent interprocess behaviour. 50 * PPB_Buffer interface for consistent interprocess behaviour.
50 */ 51 */
51 PP_Resource data; 52 PP_Resource data;
52 53
53 /** 54 /**
54 * Size of the bitstream contained in buffer (in bytes). 55 * Size of the bitstream contained in buffer (in bytes).
55 */ 56 */
56 uint32_t size; 57 uint32_t size;
57 }; 58 };
58 59
59 /** 60 /**
60 * Struct for specifying texture-backed picture data. 61 * Struct for specifying texture-backed picture data.
61 */ 62 */
62 [assert_size(16)] 63 [assert_size(16)]
63 struct PP_PictureBuffer_Dev { 64 struct PP_PictureBuffer_Dev {
64 /** 65 /**
65 * Client-specified id for the picture buffer. By using this value client can 66 * Client-specified id for the picture buffer. By using this value client can
66 * keep track of the buffers it has assigned to the video decoder and how they 67 * keep track of the buffers it has assigned to the video decoder and how they
67 * are passed back to it. 68 * are passed back to it. Valid values are non-negative.
68 */ 69 */
69 int32_t id; 70 int32_t id;
70 71
71 /** 72 /**
72 * Dimensions of the buffer. 73 * Dimensions of the buffer.
73 */ 74 */
74 PP_Size size; 75 PP_Size size;
75 76
76 /** 77 /**
77 * Texture ID in the given context where picture is stored. 78 * Texture ID in the given context where picture is stored.
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 */ 118 */
118 PP_VIDEODECODERERROR_UNREADABLE_INPUT = 3, 119 PP_VIDEODECODERERROR_UNREADABLE_INPUT = 3,
119 120
120 /** 121 /**
121 * A failure occurred at the browser layer or lower. Examples of such 122 * A failure occurred at the browser layer or lower. Examples of such
122 * failures include GPU hardware failures, GPU driver failures, GPU library 123 * failures include GPU hardware failures, GPU driver failures, GPU library
123 * failures, browser programming errors, and so on. 124 * failures, browser programming errors, and so on.
124 */ 125 */
125 PP_VIDEODECODERERROR_PLATFORM_FAILURE = 4 126 PP_VIDEODECODERERROR_PLATFORM_FAILURE = 4
126 }; 127 };
OLDNEW
« no previous file with comments | « media/filters/gpu_video_decoder.cc ('k') | ppapi/c/dev/pp_video_dev.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698