IDL schema compiler: Fixed pseudo-random order

IDL schema compiler: Fixed pseudo-random order of methods, properties, and other elements due to them being parsed into an unordered dict (uses an OrderedDict instead).

The API documentation now displays items in their original IDL order.

BUG=168965
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177664

[Matt Giuca, 2013-01-14 01:00:06]

Hi Ben,

Would you be able to take a look at this CL? (I chose you because you looked at
a similar one last week.)

I've updated and run the Python tests. However, I noticed a C++ test in
tools/json_schema_compiler/test/idl_schemas_unittest.cc, which I don't know how
to run. (It has a .gyp file, but I'm not sure of what command to run -- I use
ninja on Linux.) Can you offer any suggestion on how to run this test?

[not at google - send to devlin, 2013-01-14 15:26:25]

lgtm

It looks like idl_schema_unittest.cc is part of unit_tests so you'd run it by
compiling unit_tests then running "out/Debug/unit_tests
--gtest_filter=IdlCompiler.*'.

https://codereview.chromium.org/11826020/diff/2001/tools/json_schema_compiler...
File tools/json_schema_compiler/idl_schema.py (right):

https://codereview.chromium.org/11826020/diff/2001/tools/json_schema_compiler...
tools/json_schema_compiler/idl_schema.py:20: from simplejson import OrderedDict
hm, we already have logic which does this in json_parse.py. You should use that
(see model.py).

[Matt Giuca, 2013-01-17 05:30:53]

I've fixed the IdlCompiler test. Committing.

https://codereview.chromium.org/11826020/diff/2001/tools/json_schema_compiler...
File tools/json_schema_compiler/idl_schema.py (right):

https://codereview.chromium.org/11826020/diff/2001/tools/json_schema_compiler...
tools/json_schema_compiler/idl_schema.py:20: from simplejson import OrderedDict
On 2013/01/14 15:26:25, kalman wrote:
> hm, we already have logic which does this in json_parse.py. You should use
that
> (see model.py).

Done.

[commit-bot: I haz the power, 2013-01-17 05:31:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/11826020/10001

[commit-bot: I haz the power, 2013-01-18 05:17:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/11826020/10001

[commit-bot: I haz the power, 2013-01-18 05:17:48]

Failed to apply patch for tools/json_schema_compiler/idl_schema_test.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/json_schema_compiler/idl_schema_test.py
  Hunk #1 FAILED at 60.
  1 out of 1 hunk FAILED -- saving rejects to file
tools/json_schema_compiler/idl_schema_test.py.rej

Patch:       tools/json_schema_compiler/idl_schema_test.py
Index: tools/json_schema_compiler/idl_schema_test.py
diff --git a/tools/json_schema_compiler/idl_schema_test.py
b/tools/json_schema_compiler/idl_schema_test.py
index
a4fd0d859aca3e1c490b3bfeecde0a27effe3343..23843225d9833118f6803cd5e6589a2432951884
100755
--- a/tools/json_schema_compiler/idl_schema_test.py
+++ b/tools/json_schema_compiler/idl_schema_test.py
@@ -60,9 +60,18 @@ class IdlSchemaTest(unittest.TestCase):
     self.assertEquals({
         'x': {'name': 'x', 'type': 'integer', 'enum': [1,2],
               'description': 'This comment tests "double-quotes".'},
-        'y': {'name': 'y', 'type': 'string'}},
+        'y': {'name': 'y', 'type': 'string'},
+        'z': {'name': 'z', 'type': 'string'},
+        'a': {'name': 'a', 'type': 'string'},
+        'b': {'name': 'b', 'type': 'string'},
+        'c': {'name': 'c', 'type': 'string'}},
       getType(self.idl_basics, 'idl_basics.MyType1')['properties'])
 
+  def testMemberOrdering(self):
+    self.assertEquals(
+        ['x', 'y', 'z', 'a', 'b', 'c'],
+        getType(self.idl_basics, 'idl_basics.MyType1')['properties'].keys())
+
   def testEnum(self):
     schema = self.idl_basics
     expected = {'enum': ['name1', 'name2'], 'description': 'Enum description',

[commit-bot: I haz the power, 2013-01-18 06:10:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/11826020/24002

[commit-bot: I haz the power, 2013-01-18 14:11:31]

Change committed as 177664