Pressing control closes any open bookmark bar folder

Reverting fix for crbug.com/138309 which caused this problem (Filed bug crbug.com/168910 to re-fix 138309 differently).

The fix for crbug.com/138309 dismisses context menus on ChromeOS when Ctrl or Alt is pressed.
This prevents context menus that allow for Ctrl clicks to work (because they are closed prematurely).

The problem that the fix for 138309 tried to address is that "tab navigation" short-cuts work but leave
context menus up. These types of shortcuts should either be blocked or dismiss the context menu.

For more info see:
crbug.com/167539 (this bug)
crbug.com/138309 (bug fix being reverted)
crbug.com/168910 (replica of 138309)

BUG=167539
TEST=manual:
Create bookmark folder with entries
Click on bookmark folder 
Control Click on an entry

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175715

[tfarina, 2013-01-09 00:10:57]

On Tue, Jan 8, 2013 at 10:07 PM,  <sschmitz@chromium.org> wrote:
> Reviewers: sky,
>
> Description:
> Reverting fix for crbug.com/138309 which caused this.

which caused ... ? Can you describe in more detail what you are fixing?

> I will file a new bug
> for
> fixing 138309 again.
>
"I'll file a new bug for..." is not a good commit message. It's just
informing what are your plans for future. It don't describe what you
are fixing nor why.

Can you improve this CL description?

Thanks,

>
> BUG=167539
> TEST=manual:
> Create bookmark folder with entries
> Click on bookmark folder
> Control Click on an entry
>
What is the expected behavior?

>
> Please review this at https://codereview.chromium.org/11826012/
>

-- 
Thiago

[sschmitz, 2013-01-09 00:37:51]

I updated the description. That info is available in the referred to bugs. Is
that not enough?

[tfarina, 2013-01-09 00:41:49]

On Tue, Jan 8, 2013 at 10:37 PM,  <sschmitz@chromium.org> wrote:
> I updated the description.
Thanks!

> That info is available in the referred to bugs. Is that not enough?
>
Nope, the bug tracker might be down, lost, or something else. All
relevant info should be in the commit message if possible (see the
recent thread on chromium-dev from Carlos Pizano - cpu). So someone
reading it in future can figure out alone without having to dig into
the BUG.

>
> https://codereview.chromium.org/11826012/



-- 
Thiago

[sky, 2013-01-09 00:53:53]

LGTM

[commit-bot: I haz the power, 2013-01-09 00:57:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/11826012/1

[commit-bot: I haz the power, 2013-01-09 05:35:36]

Change committed as 175715