Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 11826011: [Autofill] Loosen thread-safety DCHECK in AutofillCountry so that tests will pass when run in isola… (Closed)

Created:
7 years, 11 months ago by Ilya Sherman
Modified:
7 years, 11 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

[Autofill] Loosen thread-safety DCHECK in AutofillCountry so that tests will pass when run in isolation. BUG=100845, 122995, 123009 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/autofill/autofill_country.cc View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ilya Sherman
7 years, 11 months ago (2013-01-08 23:50:34 UTC) #1
dhollowa
lgtm
7 years, 11 months ago (2013-01-09 00:32:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11826011/1
7 years, 11 months ago (2013-01-09 00:40:33 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-09 03:14:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11826011/1
7 years, 11 months ago (2013-01-09 04:32:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) content_browsertests
7 years, 11 months ago (2013-01-09 05:52:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11826011/1
7 years, 11 months ago (2013-01-09 08:48:42 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 10:29:34 UTC) #8
Message was sent while issue was closed.
Change committed as 175768

Powered by Google App Engine
This is Rietveld 408576698