Issue 11825006: Make all base targets build on Win64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11825006: Make all base targets build on Win64 (Closed)

Created:
7 years, 11 months ago by jschuh

Modified:
7 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make all base targets build on Win64 BUG=166496 BUG=167187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175916

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	base/base.gyp	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
	M	base/cpu_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://codereview.chromium.org/11825006/diff/1/base/base.gyp File base/base.gyp (right): https://codereview.chromium.org/11825006/diff/1/base/base.gyp#newcode275 base/base.gyp:275: 4267, Can you add a comment here about ...

7 years, 11 months ago (2013-01-09 19:20:05 UTC) #2

jschuh

https://codereview.chromium.org/11825006/diff/1/base/base.gyp File base/base.gyp (right): https://codereview.chromium.org/11825006/diff/1/base/base.gyp#newcode275 base/base.gyp:275: 4267, On 2013/01/09 19:20:05, brettw wrote: > Can you ...

7 years, 11 months ago (2013-01-09 20:42:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/11825006/7001

7 years, 11 months ago (2013-01-09 20:43:54 UTC) #4

Message was sent while issue was closed.

Change committed as 175916

Expand Messages | Collapse Messages

Issue 11825006: Make all base targets build on Win64 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages