Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 11825003: Move headers (Closed)

Created:
7 years, 11 months ago by noelallen1
Modified:
7 years, 11 months ago
Reviewers:
binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Move headers Host and NaCl builds currently use different headers which can cause build problems. This change moves the headers out of the toolchains and instead all toolchains share the same set as the host builds. NOTRY=true BUG=168718 R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175666

Patch Set 1 #

Patch Set 2 : Rename include path var #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -44 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 6 chunks +37 lines, -43 lines 2 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
noelallen1
PTaL
7 years, 11 months ago (2013-01-08 21:32:59 UTC) #1
binji
probably should change the -idirafter to just -I now (in common.mk). It was used before ...
7 years, 11 months ago (2013-01-08 21:51:25 UTC) #2
noelallen1
I will put the "include after" change in the makefile cleanup cl. https://codereview.chromium.org/11825003/diff/2001/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py ...
7 years, 11 months ago (2013-01-08 23:28:22 UTC) #3
binji
ok, lgtm
7 years, 11 months ago (2013-01-08 23:31:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/11825003/2001
7 years, 11 months ago (2013-01-09 00:23:24 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 01:59:37 UTC) #6
Message was sent while issue was closed.
Change committed as 175666

Powered by Google App Engine
This is Rietveld 408576698