Encrypted Media: Update config/state after config changed in DecryptingAudioDecoder.

Encrypted Media: Update config/state after config changed in DecryptingAudioDecoder.

BUG=169266
TEST=updated unittest to cover this


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176548

[xhwang, 2013-01-10 18:18:44]

This CL fixes a bug that isn't firing right now but may fire later when
SourceBufferStream loosens it's restriction on how audio config can be changed.
PTAL!

[DaleCurtis, 2013-01-10 21:47:08]

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
File media/filters/decrypting_audio_decoder_unittest.cc (right):

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
media/filters/decrypting_audio_decoder_unittest.cc:359: AudioDecoderConfig
new_config(kCodecVorbis, kSampleFormatPlanarS16,
Won't this fail until your other change lands?

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
media/filters/decrypting_audio_decoder_unittest.cc:380:
EXPECT_EQ(new_config.bits_per_channel(), decoder_->bits_per_channel());
Ditto.

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
media/filters/decrypting_audio_decoder_unittest.cc:488:
EXPECT_NE(new_config.bits_per_channel(), config_.bits_per_channel());
Ditto.

[xhwang, 2013-01-11 04:02:45]

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
File media/filters/decrypting_audio_decoder_unittest.cc (right):

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
media/filters/decrypting_audio_decoder_unittest.cc:359: AudioDecoderConfig
new_config(kCodecVorbis, kSampleFormatPlanarS16,
On 2013/01/10 21:47:08, DaleCurtis wrote:
> Won't this fail until your other change lands?

This should work :) I just need a different config here. It doesn't matter what
the config is.

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
media/filters/decrypting_audio_decoder_unittest.cc:380:
EXPECT_EQ(new_config.bits_per_channel(), decoder_->bits_per_channel());
On 2013/01/10 21:47:08, DaleCurtis wrote:
> Ditto.

ditto :)

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
media/filters/decrypting_audio_decoder_unittest.cc:488:
EXPECT_NE(new_config.bits_per_channel(), config_.bits_per_channel());
On 2013/01/10 21:47:08, DaleCurtis wrote:
> Ditto.

ditto :)

[ddorwin, 2013-01-11 05:19:57]

LGTM % comment. I defer to Dale on audio mechanics.

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
File media/filters/decrypting_audio_decoder.cc (right):

https://codereview.chromium.org/11824066/diff/5/media/filters/decrypting_audi...
media/filters/decrypting_audio_decoder.cc:446: void
DecryptingAudioDecoder::SetDecoderConfig() {
I think it would be better to pass in the thing we're setting
(AudioDecoderConfig). Otherwise, it's not obvious what the function does without
looking at it.

[xhwang, 2013-01-11 22:30:15]

dalecurtis: comments replied. do you want to take a look again?

[DaleCurtis, 2013-01-12 01:33:05]

lgtm

[commit-bot: I haz the power, 2013-01-12 01:37:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/11824066/8001

[commit-bot: I haz the power, 2013-01-12 16:55:26]

Change committed as 176548