Add unittest for google_apis::GetAboutOperation.

Add unittest for google_apis::GetAboutOperation.

This CL adds test cases for google_apis::GetAboutOperation.
Also, it naturally introduces the testing base code for the operations
communicating with a drive api server, so that it will be reused for unit tests
of other operation classes in drive_api_operations.{h,cc} later.

BUG=162155
TEST=Ran unit_tests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176066

[hidehiko, 2013-01-09 16:39:09]

Lei, could you kindly review a .gypi file?
Satoru, Kazuhiro, could you take a look at all the other codes?

Thank you for your review in advance,
- hidehiko

[Lei Zhang, 2013-01-09 19:56:28]

.gypi file lgtm

[satorux1, 2013-01-10 01:07:41]

https://codereview.chromium.org/11824023/diff/7/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_api_operations_unittest.cc (right):

https://codereview.chromium.org/11824023/diff/7/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_operations_unittest.cc:35: void
CopyResultFromGetDataCallbackAndQuit(
Please move this to test_util.cc so we can share this with
gdata_wapi_operations_unittest.cc.

https://codereview.chromium.org/11824023/diff/7/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_operations_unittest.cc:80:
EXPECT_PRED_FORMAT2(AssertJsonFile, file_path, json_value)
Hmm, I think this looks a bit too tricky. I think a function that returns bool
would be easier to read. Here's what we do in gdata_wapi_operations_unittest.cc

  EXPECT_TRUE(VerifyJsonData(
      test_util::GetTestFilePath("gdata/root_feed.json"),
      result_data.get()));

[hidehiko, 2013-01-10 04:00:16]

Thank you for your review.

Satoru, could you take another look?

https://codereview.chromium.org/11824023/diff/7/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_api_operations_unittest.cc (right):

https://codereview.chromium.org/11824023/diff/7/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_operations_unittest.cc:35: void
CopyResultFromGetDataCallbackAndQuit(
On 2013/01/10 01:07:41, satorux1 wrote:
> Please move this to test_util.cc so we can share this with
> gdata_wapi_operations_unittest.cc.
> 

Done. Ditto for DoNothingForReAuthenticateCallback.

https://codereview.chromium.org/11824023/diff/7/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_operations_unittest.cc:80:
EXPECT_PRED_FORMAT2(AssertJsonFile, file_path, json_value)
On 2013/01/10 01:07:41, satorux1 wrote:
> Hmm, I think this looks a bit too tricky. I think a function that returns bool
> would be easier to read. Here's what we do in
gdata_wapi_operations_unittest.cc
> 
>   EXPECT_TRUE(VerifyJsonData(
>       test_util::GetTestFilePath("gdata/root_feed.json"),
>       result_data.get()));

Indeed, but the way looses the reason why the test is failed. Could you kindly
tell me the chromeos's manner to keep the failure reason and its context (i.e.
where it failed) in the test failure logs? Is there any example I can refer
(unfortunately, I cannot find good examples...)?
One of the alternative ways should be copy'n'pasting simpler EXPECT_XXX in
TEST_F methods, but it'd cause lots of duplication. Is it acceptable in
chromeos?

[satorux1, 2013-01-10 05:53:07]

LGTM. Thanks!

[kinaba, 2013-01-10 05:54:47]

lgtm++

[commit-bot: I haz the power, 2013-01-10 05:58:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/11824023/16001

[commit-bot: I haz the power, 2013-01-10 08:34:56]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-10 08:37:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/11824023/16001

[commit-bot: I haz the power, 2013-01-10 14:17:57]

Change committed as 176066