Add test to ensure Chrome welcome page loads on Android.

Add test to ensure Chrome welcome page loads on Android.

There are no tests currently that ensure that any chrome:// pages load
for Android, and there have been times where they have stopped loading,
but no test caught this.

This adds a test that loads chrome://welcome/ in the Chromium test
shell, and ensure it does not show an interstitial page, and that the
title and URL look sane.

BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176345

[nyquist, 2013-01-10 21:20:12]

jcivelli: PTAL

[Jay Civelli, 2013-01-10 21:24:05]

lgtm

[commit-bot: I haz the power, 2013-01-10 21:43:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/11823063/1

[commit-bot: I haz the power, 2013-01-10 21:43:41]

Presubmit check for 11823063-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/android

[nyquist, 2013-01-10 21:45:11]

yfriedman: owners rubberstamp?

[Yaron, 2013-01-10 22:02:06]

https://codereview.chromium.org/11823063/diff/1/chrome/android/testshell/java...
File
chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java
(right):

https://codereview.chromium.org/11823063/diff/1/chrome/android/testshell/java...
chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java:59:
contentViewCore.set(contentView.get().getContentViewCore());
Why not get ContentView/ContentViewCore in one runnable

https://codereview.chromium.org/11823063/diff/1/chrome/android/testshell/java...
chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java:80:
assertTrue(url.get().contains(welcomeUrl));
Output what it was in failure message.

https://codereview.chromium.org/11823063/diff/1/chrome/android/testshell/java...
chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java:82:
assertFalse("Welcome page should have been loaded.",
same

[nyquist, 2013-01-10 22:47:03]

Addressed comments.
yfriedman: PTAL

https://codereview.chromium.org/11823063/diff/1/chrome/android/testshell/java...
File
chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java
(right):

https://codereview.chromium.org/11823063/diff/1/chrome/android/testshell/java...
chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java:59:
contentViewCore.set(contentView.get().getContentViewCore());
On 2013/01/10 22:02:07, Yaron wrote:
> Why not get ContentView/ContentViewCore in one runnable

Done.

https://codereview.chromium.org/11823063/diff/1/chrome/android/testshell/java...
chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java:80:
assertTrue(url.get().contains(welcomeUrl));
On 2013/01/10 22:02:07, Yaron wrote:
> Output what it was in failure message.

Done.

https://codereview.chromium.org/11823063/diff/1/chrome/android/testshell/java...
chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellUrlTest.java:82:
assertFalse("Welcome page should have been loaded.",
On 2013/01/10 22:02:07, Yaron wrote:
> same

Done.

[Yaron, 2013-01-11 01:12:52]

lgtm

[commit-bot: I haz the power, 2013-01-11 03:06:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/11823063/8001

[commit-bot: I haz the power, 2013-01-11 13:36:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/11823063/8001

[commit-bot: I haz the power, 2013-01-11 13:45:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/11823063/8001

[commit-bot: I haz the power, 2013-01-11 13:54:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/11823063/8001

[commit-bot: I haz the power, 2013-01-11 15:24:24]

Change committed as 176345