Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 11823032: Minor enhancements to android buildbot bb_run_bot (Closed)

Created:
7 years, 11 months ago by Isaac (away)
Modified:
7 years, 11 months ago
Reviewers:
cmp
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Mike Stip (use stip instead)
Visibility:
Public.

Description

Minor enhancements to android buildbot bb_run_bot Changes in preparation to moving buildbot config to point directly to this file. - Improved substring bot-id matching. Because we're using an unordered dict, look for all possible bot-id substring matches and pick the longest one, instead of picking the first substring match. Added generic 'builder' bot-id that several bots will use. - Changed factory_property key to 'android_bot_id' to make it more clear where this value is used and easier to search for. R=cmp NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175924

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M build/android/buildbot/bb_run_bot.py View 1 4 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Isaac (away)
7 years, 11 months ago (2013-01-09 19:19:55 UTC) #1
cmp
lgtm
7 years, 11 months ago (2013-01-09 22:01:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11823032/5001
7 years, 11 months ago (2013-01-09 23:45:03 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 23:50:54 UTC) #4
Message was sent while issue was closed.
Change committed as 175924

Powered by Google App Engine
This is Rietveld 408576698