Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2197)

Unified Diff: android_webview/renderer/aw_render_view_ext.cc

Issue 11823027: [Android WebView] Implement the capture picture API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new approach without ExternalPictureData. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/renderer/aw_render_view_ext.cc
diff --git a/android_webview/renderer/aw_render_view_ext.cc b/android_webview/renderer/aw_render_view_ext.cc
index c236112cd8e0dedb523e61a9acac93e6910f0187..5798011bfa00d496ef13b80598df2bb1e228503a 100644
--- a/android_webview/renderer/aw_render_view_ext.cc
+++ b/android_webview/renderer/aw_render_view_ext.cc
@@ -49,6 +49,8 @@ AwRenderViewExt::AwRenderViewExt(content::RenderView* render_view)
: content::RenderViewObserver(render_view) {
render_view->GetWebView()->setPermissionClient(this);
// TODO(leandrogracia): enable once the feature is available in RenderView.
+ // TODO(leandrogracia): remove when SW rendering uses Ubercompositor.
joth 2013/01/12 02:36:28 Haha It was bad enough as a TODO to enable the cod
Leandro GraciĆ” Gil 2013/01/12 17:59:14 First TODO get SW rendering work using CapturePict
+ // Until then we need the callback enabled for SW mode invalidation.
//render_view->SetCapturePictureCallback(
// base::Bind(&AwRenderViewExt::OnPictureUpdate, AsWeakPtr()));
}
@@ -72,6 +74,8 @@ bool AwRenderViewExt::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(AwViewMsg_DoHitTest, OnDoHitTest)
IPC_MESSAGE_HANDLER(AwViewMsg_EnableCapturePictureCallback,
OnEnableCapturePictureCallback)
+ IPC_MESSAGE_HANDLER_DELAY_REPLY(AwViewMsg_CapturePictureSync,
+ OnCapturePictureSync)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -205,4 +209,11 @@ void AwRenderViewExt::OnPictureUpdate(skia::RefPtr<SkPicture> picture) {
Send(new AwViewHostMsg_PictureUpdated(routing_id()));
}
+void AwRenderViewExt::OnCapturePictureSync(IPC::Message* reply_msg) {
+ // TODO(leandrogracia): enable once the feature is available in RenderView.
+ //RendererPictureMap::GetInstance()->SetRendererPicture(
+ // routing_id(), render_view()->CapturePicture());
+ Send(reply_msg);
+}
+
} // namespace android_webview
« android_webview/public/browser/draw_sw.h ('K') | « android_webview/renderer/aw_render_view_ext.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698