Adding some new DumpAccessibilityTree tests, tweaking DumpAccessibilityTree helpers and fixing a bug

- New tests for address, aria-autocomplete, aria-invalid, ARIA menuitemradio, ARIA progressbar, ARIA toolbar, bdo, br, input type="button" (in a menu), input type="image" (in a menu), select (with NO multiple attribute) and wbr
- Tweaks to dump_accessibility_tree_helper_win.cc to print out min and max values and use the public API to get the current value
- Tweaks to dump_accessibility_tree_helper_mac.mm to print out the minimum and maximum values, valueDescription and invalid state
- Tweaks to browser_accessibility_cocoa.{mm,h} to add an invalid() method
- Fix a bug in accessibility_node_serializer.cc where minimum and maximum values were getting swapped.

BUG=168805
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176769

[dmazzoni, 2013-01-12 00:01:32]

Great!

lgtm with nits; please feel free to submit once this passes trybots.

https://codereview.chromium.org/11823026/diff/31001/content/browser/accessibi...
File content/browser/accessibility/dump_accessibility_tree_helper_win.cc
(right):

https://codereview.chromium.org/11823026/diff/31001/content/browser/accessibi...
content/browser/accessibility/dump_accessibility_tree_helper_win.cc:72:
Add(false, StringPrintf(L"value=%.2f", V_R8(&value)));
Call this numericValue or rangeValue or something like that...to distinguish it
from the IAccessible "value" attribute that can only contain a string.

https://codereview.chromium.org/11823026/diff/31001/content/test/data/accessi...
File content/test/data/accessibility/address-expected-win.txt (right):

https://codereview.chromium.org/11823026/diff/31001/content/test/data/accessi...
content/test/data/accessibility/address-expected-win.txt:2: - role:address not
set. http://crbug.com/169568>
On Windows, the aria role is reported in an attribute called xml-roles, for
historic reasons. See if it outputs xml-roles:address.

https://codereview.chromium.org/11823026/diff/31001/content/test/data/accessi...
File content/test/data/accessibility/aria-menuitemradio.html (right):

https://codereview.chromium.org/11823026/diff/31001/content/test/data/accessi...
content/test/data/accessibility/aria-menuitemradio.html:11: <div
role="aria-menuitemradio" aria-checked>Menu item 1</div>
Should just be role="menuitemradio", no aria in the role.

Should you put this in a container with role=menu?

[aboxhall, 2013-01-12 02:41:46]

https://codereview.chromium.org/11823026/diff/31001/content/browser/accessibi...
File content/browser/accessibility/dump_accessibility_tree_helper_win.cc
(right):

https://codereview.chromium.org/11823026/diff/31001/content/browser/accessibi...
content/browser/accessibility/dump_accessibility_tree_helper_win.cc:72:
Add(false, StringPrintf(L"value=%.2f", V_R8(&value)));
On 2013/01/12 00:01:32, Dominic Mazzoni wrote:
> Call this numericValue or rangeValue or something like that...to distinguish
it
> from the IAccessible "value" attribute that can only contain a string.

Done.

https://codereview.chromium.org/11823026/diff/31001/content/test/data/accessi...
File content/test/data/accessibility/address-expected-win.txt (right):

https://codereview.chromium.org/11823026/diff/31001/content/test/data/accessi...
content/test/data/accessibility/address-expected-win.txt:2: - role:address not
set. http://crbug.com/169568>
On 2013/01/12 00:01:32, Dominic Mazzoni wrote:
> On Windows, the aria role is reported in an attribute called xml-roles, for
> historic reasons. See if it outputs xml-roles:address.

I checked and it doesn't. This is an <address> element, so it outputs
tag:address:
http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/99036/...

https://codereview.chromium.org/11823026/diff/31001/content/test/data/accessi...
File content/test/data/accessibility/aria-menuitemradio.html (right):

https://codereview.chromium.org/11823026/diff/31001/content/test/data/accessi...
content/test/data/accessibility/aria-menuitemradio.html:11: <div
role="aria-menuitemradio" aria-checked>Menu item 1</div>
On 2013/01/12 00:01:32, Dominic Mazzoni wrote:
> Should just be role="menuitemradio", no aria in the role.
> 
> Should you put this in a container with role=menu?

Done, although it doesn't actually make any difference as it turns out.

[commit-bot: I haz the power, 2013-01-13 02:18:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/11823026/44002

[commit-bot: I haz the power, 2013-01-13 02:18:28]

Presubmit check for 11823026-44002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/renderer

Presubmit checks took 2.9s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[aboxhall, 2013-01-14 17:39:47]

jamesr, would you be able to review the changes to content/renderer/?

[jamesr, 2013-01-14 21:08:48]

content/renderer lgtm

[commit-bot: I haz the power, 2013-01-14 21:10:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/11823026/44002

[commit-bot: I haz the power, 2013-01-15 00:44:49]

Change committed as 176769