Remove DCHECK for negative sizes for Android

Remove DCHECK for negative sizes for Android

There are still places in downstream Android code where a negative size
is provided as width or height to the SizeBase template for set_width,
set_height and the constructor.

The DCHECK was added in:
https://chromiumcodereview.appspot.com/11410024

BUG=168927
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175723

[nyquist, 2013-01-09 01:39:19]

aelias: PTAL

[danakj, 2013-01-09 01:41:49]

If the problems are all downstream, can this CL also be downstream?

[nyquist, 2013-01-09 01:44:04]

On 2013/01/09 01:41:49, danakj wrote:
> If the problems are all downstream, can this CL also be downstream?

I believe it would have to be fixed many places downstream, as this is part of a
template that is used many times. I might be wrong though.

[danakj, 2013-01-09 01:49:11]

On 2013/01/09 01:44:04, nyquist wrote:
> On 2013/01/09 01:41:49, danakj wrote:
> > If the problems are all downstream, can this CL also be downstream?
> 
> I believe it would have to be fixed many places downstream, as this is part of
a
> template that is used many times. I might be wrong though.

I mean, why not edit this file in the same way in the downstream repo to resolve
downstream bugs?

[nyquist, 2013-01-09 01:50:17]

On 2013/01/09 01:49:11, danakj wrote:
> On 2013/01/09 01:44:04, nyquist wrote:
> > On 2013/01/09 01:41:49, danakj wrote:
> > > If the problems are all downstream, can this CL also be downstream?
> > 
> > I believe it would have to be fixed many places downstream, as this is part
of
> a
> > template that is used many times. I might be wrong though.
> 
> I mean, why not edit this file in the same way in the downstream repo to
resolve
> downstream bugs?

We do not have a fork of the chromium repository downstream anymore, so that is
not possible.

[danakj, 2013-01-09 01:53:21]

https://codereview.chromium.org/11823012/diff/1/ui/gfx/size_base_impl.h
File ui/gfx/size_base_impl.h (right):

https://codereview.chromium.org/11823012/diff/1/ui/gfx/size_base_impl.h#newco...
ui/gfx/size_base_impl.h:19: #if !defined(OS_ANDROID)
can you stick a todo here to remove this with the bug #

[nyquist, 2013-01-09 01:57:44]

Added TODO

https://codereview.chromium.org/11823012/diff/1/ui/gfx/size_base_impl.h
File ui/gfx/size_base_impl.h (right):

https://codereview.chromium.org/11823012/diff/1/ui/gfx/size_base_impl.h#newco...
ui/gfx/size_base_impl.h:19: #if !defined(OS_ANDROID)
On 2013/01/09 01:53:21, danakj wrote:
> can you stick a todo here to remove this with the bug #

Done.

[danakj, 2013-01-09 02:00:40]

Thanks, LGTM

[commit-bot: I haz the power, 2013-01-09 02:55:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/11823012/6002

[commit-bot: I haz the power, 2013-01-09 05:21:50]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-09 05:23:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/11823012/6002

[commit-bot: I haz the power, 2013-01-09 07:23:01]

Change committed as 175723