Fix some pecularities in my C++ style for achuith@.

Fix some pecularities in my C++ style for achuith@.

R=achuith@chromium.org
BUG=None
TEST=PromoResourceServiceTest.NotificationPromoTest passes on bots and doesn't
hurt achuith@'s eyes so much.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175851

[achuithb, 2013-01-08 22:44:43]

https://codereview.chromium.org/11823007/diff/3001/chrome/browser/web_resourc...
File chrome/browser/web_resource/promo_resource_service_unittest.cc (right):

https://codereview.chromium.org/11823007/diff/3001/chrome/browser/web_resourc...
chrome/browser/web_resource/promo_resource_service_unittest.cc:35: bool
YearFromNow(double* date_double, std::string* date_string) {
You still need a function comment. Can we rename date_double to date_epoch or
date_msec instead?

https://codereview.chromium.org/11823007/diff/3001/chrome/browser/web_resourc...
chrome/browser/web_resource/promo_resource_service_unittest.cc:91: double
year_from_now_double;
year_from_now_epoch or year_from_now_msec?

[Dan Beam, 2013-01-08 22:53:06]

https://codereview.chromium.org/11823007/diff/3001/chrome/browser/web_resourc...
File chrome/browser/web_resource/promo_resource_service_unittest.cc (right):

https://codereview.chromium.org/11823007/diff/3001/chrome/browser/web_resourc...
chrome/browser/web_resource/promo_resource_service_unittest.cc:35: bool
YearFromNow(double* date_double, std::string* date_string) {
On 2013/01/08 22:44:43, achuith.bhandarkar wrote:
> You still need a function comment. Can we rename date_double to date_epoch or
> date_msec instead?

Done.

https://codereview.chromium.org/11823007/diff/3001/chrome/browser/web_resourc...
chrome/browser/web_resource/promo_resource_service_unittest.cc:91: double
year_from_now_double;
On 2013/01/08 22:44:43, achuith.bhandarkar wrote:
> year_from_now_epoch or year_from_now_msec?

Done.

[achuithb, 2013-01-08 22:57:53]

lgtm.

Thanks for fixing the nits!

[commit-bot: I haz the power, 2013-01-09 00:06:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11823007/9001

[commit-bot: I haz the power, 2013-01-09 04:41:52]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-09 07:01:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11823007/9001

[commit-bot: I haz the power, 2013-01-09 09:22:30]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-09 09:48:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11823007/9001

[commit-bot: I haz the power, 2013-01-09 11:30:19]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-09 18:35:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11823007/9001

[commit-bot: I haz the power, 2013-01-09 19:25:48]

Change committed as 175851