src/liveedit.cc - Issue 11821049: Combine DEBUG_BREAK and DEBUG_PREPARE_STEP_IN into one IC stub kind DEBUG_STUB, encoding DEBUG_BREA…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/liveedit.cc

Issue 11821049: Combine DEBUG_BREAK and DEBUG_PREPARE_STEP_IN into one IC stub kind DEBUG_STUB, encoding DEBUG_BREA… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/liveedit.cc

diff --git a/src/liveedit.cc b/src/liveedit.cc

index a981f47b128d6bcee141989d026e087f7e46be12..dc6f353e99c5135d283a8ecf2997b4dff5126688 100644

--- a/src/liveedit.cc

+++ b/src/liveedit.cc

@@ -1663,7 +1663,8 @@ static const char* DropFrames(Vector<StackFrame*> frames,

Code* pre_top_frame_code = pre_top_frame->LookupCode();

bool frame_has_padding;

if (pre_top_frame_code->is_inline_cache_stub() &&

- pre_top_frame_code->ic_state() == DEBUG_BREAK) {

+ pre_top_frame_code->ic_state() == DEBUG_STUB &&

+ pre_top_frame_code->extra_ic_state() == DEBUG_BREAK) {

Yang 2013/01/10 14:06:47 maybe introduce a is_debug_break() predicate to sh

// OK, we can drop inline cache calls.

*mode = Debug::FRAME_DROPPED_IN_IC_CALL;

frame_has_padding = Debug::FramePaddingLayout::kIsSupported;

« no previous file with comments | « src/ic.cc ('k') | src/objects.cc » ('j') | no next file with comments »