Return false in AwWebContentsDelegate::CanDownload

Return false in AwWebContentsDelegate::CanDownload

Android webview intercepts download in its resource dispatcher host delegate

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175708

[boliu, 2013-01-09 00:47:46]

lgtm

+joth for owner stamp

https://codereview.chromium.org/11821011/diff/1/android_webview/native/aw_web...
File android_webview/native/aw_web_contents_delegate.cc (right):

https://codereview.chromium.org/11821011/diff/1/android_webview/native/aw_web...
android_webview/native/aw_web_contents_delegate.cc:58: return false;
could you put a NOTREACHED here?

[joth, 2013-01-09 00:53:17]

lgtm

https://codereview.chromium.org/11821011/diff/1/android_webview/native/aw_web...
File android_webview/native/aw_web_contents_delegate.cc (right):

https://codereview.chromium.org/11821011/diff/1/android_webview/native/aw_web...
android_webview/native/aw_web_contents_delegate.cc:58: return false;
On 2013/01/09 00:47:46, boliu wrote:
> could you put a NOTREACHED here?
+1

also lets add a comment to explain why:
// Android webview intercepts download in its resource dispatcher host delegate,
so should not reach here. (Note this method is actually an internal detail of
chrome/ layer and doesn't really belong on the WebContentsDelegate interface)

[nilesh, 2013-01-09 01:01:38]

Thanks for the review.

https://codereview.chromium.org/11821011/diff/1/android_webview/native/aw_web...
File android_webview/native/aw_web_contents_delegate.cc (right):

https://codereview.chromium.org/11821011/diff/1/android_webview/native/aw_web...
android_webview/native/aw_web_contents_delegate.cc:58: return false;
On 2013/01/09 00:53:18, joth wrote:
> On 2013/01/09 00:47:46, boliu wrote:
> > could you put a NOTREACHED here?
> +1
> 
> also lets add a comment to explain why:
> // Android webview intercepts download in its resource dispatcher host
delegate,
> so should not reach here. (Note this method is actually an internal detail of
> chrome/ layer and doesn't really belong on the WebContentsDelegate interface)

Added NOTREACHED and explanation.
I have skipped the "Note" as it does not feel appropriate here in the
implementation. Let me know if you feel strongly about it.

[commit-bot: I haz the power, 2013-01-09 02:00:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11821011/5

[commit-bot: I haz the power, 2013-01-09 04:51:15]

Change committed as 175708