Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5579)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc

Issue 11821009: move 'web_accessible_resources' parsing out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse
Patch Set: patch rebased Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc
index 8001d9feb6d138f952e62c3243fa2c2cb95407ce..8b78ad5c8e31f6b9bdac67c4d5e9aebd95fd970c 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc
@@ -15,57 +15,6 @@ using extensions::Extension;
namespace errors = extension_manifest_errors;
-TEST_F(ExtensionManifestTest, WebAccessibleResources) {
- // Manifest version 2 with web accessible resources specified.
- scoped_refptr<Extension> extension1(
- LoadAndExpectSuccess("web_accessible_resources_1.json"));
-
- // Manifest version 2 with no web accessible resources.
- scoped_refptr<Extension> extension2(
- LoadAndExpectSuccess("web_accessible_resources_2.json"));
-
- // Default manifest version with web accessible resources specified.
- scoped_refptr<Extension> extension3(
- LoadAndExpectSuccess("web_accessible_resources_3.json"));
-
- // Default manifest version with no web accessible resources.
- scoped_refptr<Extension> extension4(
- LoadAndExpectSuccess("web_accessible_resources_4.json"));
-
- // Default manifest version with wildcard web accessible resource.
- scoped_refptr<Extension> extension5(
- LoadAndExpectSuccess("web_accessible_resources_5.json"));
-
- // Default manifest version with wildcard with specific path and extension.
- scoped_refptr<Extension> extension6(
- LoadAndExpectSuccess("web_accessible_resources_6.json"));
-
- EXPECT_TRUE(extension1->HasWebAccessibleResources());
- EXPECT_FALSE(extension2->HasWebAccessibleResources());
- EXPECT_TRUE(extension3->HasWebAccessibleResources());
- EXPECT_FALSE(extension4->HasWebAccessibleResources());
- EXPECT_TRUE(extension5->HasWebAccessibleResources());
- EXPECT_TRUE(extension6->HasWebAccessibleResources());
-
- EXPECT_TRUE(extension1->IsResourceWebAccessible("test"));
- EXPECT_FALSE(extension1->IsResourceWebAccessible("none"));
-
- EXPECT_FALSE(extension2->IsResourceWebAccessible("test"));
-
- EXPECT_TRUE(extension3->IsResourceWebAccessible("test"));
- EXPECT_FALSE(extension3->IsResourceWebAccessible("none"));
-
- EXPECT_TRUE(extension4->IsResourceWebAccessible("test"));
- EXPECT_TRUE(extension4->IsResourceWebAccessible("none"));
-
- EXPECT_TRUE(extension5->IsResourceWebAccessible("anything"));
- EXPECT_TRUE(extension5->IsResourceWebAccessible("path/anything"));
-
- EXPECT_TRUE(extension6->IsResourceWebAccessible("path/anything.ext"));
- EXPECT_FALSE(extension6->IsResourceWebAccessible("anything.ext"));
- EXPECT_FALSE(extension6->IsResourceWebAccessible("path/anything.badext"));
-}
-
TEST_F(ExtensionManifestTest, AppWebUrls) {
Testcase testcases[] = {
Testcase("web_urls_wrong_type.json", errors::kInvalidWebURLs),

Powered by Google App Engine
This is Rietveld 408576698