Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5043)

Unified Diff: chrome/common/extensions/extension.h

Issue 11821009: move 'web_accessible_resources' parsing out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 2ccef0cdefbaca172a5d42c7053a263fdae9d5d3..472c103ae4b30c3c4575461377e8284b4c07b9fe 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -418,9 +418,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool ResourceMatches(const URLPatternSet& pattern_set,
const std::string& resource) const;
- // Returns true if the specified resource is web accessible.
- bool IsResourceWebAccessible(const std::string& relative_path) const;
-
// Returns true if the specified page is sandboxed (served in a unique
// origin).
bool IsSandboxedPage(const std::string& relative_path) const;
@@ -430,9 +427,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
std::string GetResourceContentSecurityPolicy(const std::string& relative_path)
const;
- // Returns true when 'web_accessible_resources' are defined for the extension.
- bool HasWebAccessibleResources() const;
-
// Returns an extension resource object. |relative_path| should be UTF8
// encoded.
ExtensionResource GetResource(const std::string& relative_path) const;
@@ -905,7 +899,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadCommands(string16* error);
bool LoadPlugins(string16* error);
bool LoadNaClModules(string16* error);
- bool LoadWebAccessibleResources(string16* error);
bool LoadSandboxedPages(string16* error);
// Must be called after LoadPlugins().
bool LoadRequirements(string16* error);
@@ -1116,9 +1109,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
scoped_ptr<extensions::Command> script_badge_command_;
extensions::CommandMap named_commands_;
- // Optional list of web accessible extension resources.
- URLPatternSet web_accessible_resources_;
-
// Optional list of extension pages that are sandboxed (served from a unique
// origin with a different Content Security Policy).
URLPatternSet sandboxed_pages_;

Powered by Google App Engine
This is Rietveld 408576698