Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: chrome/common/extensions/manifest_web_handler.cc

Issue 11821009: move 'web_accessible_resources' parsing out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/extensions/manifest_web_handler.h"
6
7 #include "base/memory/scoped_ptr.h"
8 #include "base/string_number_conversions.h"
9 #include "base/utf_string_conversions.h"
10 #include "base/values.h"
11 #include "chrome/common/extensions/extension_manifest_constants.h"
12 #include "extensions/common/error_utils.h"
13
14 namespace extensions {
15
16 namespace keys = extension_manifest_keys;
17 namespace errors = extension_manifest_errors;
18
19 namespace {
20
21 const WebAccessibleResourcesInfo* GetResourcesInfo(const Extension* extension) {
22 return static_cast<WebAccessibleResourcesInfo*>(
23 extension->GetManifestData(keys::kWebAccessibleResources));
24 }
25
26 } // namespace
27
28 WebAccessibleResourcesInfo::WebAccessibleResourcesInfo() {
29 }
30
31 WebAccessibleResourcesInfo::~WebAccessibleResourcesInfo() {
32 }
33
34 // static
35 bool WebAccessibleResourcesInfo::IsResourceWebAccessible(
36 const std::string& relative_path,
37 const Extension* extension) {
38 // For old manifest versions which do not specify web_accessible_resources
39 // we always allow resource loads.
40 if (extension->manifest_version() < 2 &&
41 !WebAccessibleResourcesInfo::HasWebAccessibleResources(extension))
42 return true;
43
44 const WebAccessibleResourcesInfo* info = GetResourcesInfo(extension);
45 return info &&
46 extension->ResourceMatches(
47 info->web_accessible_resources_, relative_path);
48 }
49
50 // static
51 bool WebAccessibleResourcesInfo::HasWebAccessibleResources(
52 const Extension* extension) {
53 const WebAccessibleResourcesInfo* info = GetResourcesInfo(extension);
54 return info && info->web_accessible_resources_.size() > 0;
55 }
56
57 WebAccessibleResourcesHandler::WebAccessibleResourcesHandler() {
58 }
59
60 WebAccessibleResourcesHandler::~WebAccessibleResourcesHandler() {
61 }
62
63 bool WebAccessibleResourcesHandler::Parse(const base::Value* value,
64 Extension* extension,
65 string16* error) {
66 scoped_ptr<WebAccessibleResourcesInfo> info(new WebAccessibleResourcesInfo);
67 const ListValue* list_value = NULL;
68 if (!value->GetAsList(&list_value)) {
69 *error = ASCIIToUTF16(errors::kInvalidWebAccessibleResourcesList);
70 return false;
71 }
72 for (size_t i = 0; i < list_value->GetSize(); ++i) {
73 std::string relative_path;
74 if (!list_value->GetString(i, &relative_path)) {
75 *error = ErrorUtils::FormatErrorMessageUTF16(
76 errors::kInvalidWebAccessibleResource, base::IntToString(i));
77 return false;
78 }
79 URLPattern pattern(URLPattern::SCHEME_EXTENSION);
80 if (pattern.Parse(extension->url().spec()) != URLPattern::PARSE_SUCCESS) {
81 *error = ErrorUtils::FormatErrorMessageUTF16(
82 errors::kInvalidURLPatternError, extension->url().spec());
83 return false;
84 }
85 while (relative_path[0] == '/')
86 relative_path = relative_path.substr(1, relative_path.length() - 1);
87 pattern.SetPath(pattern.path() + relative_path);
88 info->web_accessible_resources_.AddPattern(pattern);
89 }
90 extension->SetManifestData(keys::kWebAccessibleResources, info.release());
91 return true;
92 }
93
94 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698