Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 11821004: Remove unused VideoFrameCapturer::size_most_recent() method. (Closed)

Created:
7 years, 11 months ago by alexeypa (please no reviews)
Modified:
7 years, 11 months ago
Reviewers:
Sergey Ulanov, Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, sail+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove unused VideoFrameCapturer::size_most_recent() method. BUG=104544 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175734

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -45 lines) Patch
M remoting/capturer/video_capturer_mock_objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/capturer/video_frame_capturer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/capturer/video_frame_capturer_fake.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/capturer/video_frame_capturer_fake.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/capturer/video_frame_capturer_linux.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M remoting/capturer/video_frame_capturer_mac.mm View 2 chunks +0 lines, -5 lines 0 comments Download
M remoting/capturer/video_frame_capturer_win.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M remoting/host/desktop_session_agent.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/host/desktop_session_agent.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M remoting/host/ipc_video_frame_capturer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M remoting/host/ipc_video_frame_capturer.cc View 2 chunks +1 line, -9 lines 0 comments Download
M remoting/host/video_scheduler_unittest.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
alexeypa (please no reviews)
PTAL.
7 years, 11 months ago (2013-01-08 20:53:32 UTC) #1
Wez
Can size_most_recent() also be removed from video_frame_capturer_helper? https://codereview.chromium.org/11821004/diff/1/remoting/host/desktop_session_agent.h File remoting/host/desktop_session_agent.h (right): https://codereview.chromium.org/11821004/diff/1/remoting/host/desktop_session_agent.h#newcode237 remoting/host/desktop_session_agent.h:237: SkISize size_most_recent_; ...
7 years, 11 months ago (2013-01-08 21:05:24 UTC) #2
alexeypa (please no reviews)
> Can size_most_recent() also be removed from video_frame_capturer_helper? Not easily. VideoFrameCapturerHelper::SwapInvalidRegion depends on it. https://codereview.chromium.org/11821004/diff/1/remoting/host/desktop_session_agent.h ...
7 years, 11 months ago (2013-01-08 21:41:04 UTC) #3
Wez
lgtm
7 years, 11 months ago (2013-01-08 21:48:26 UTC) #4
Sergey Ulanov
lgtm
7 years, 11 months ago (2013-01-08 21:49:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11821004/6001
7 years, 11 months ago (2013-01-09 04:19:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11821004/6001
7 years, 11 months ago (2013-01-09 06:19:33 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 07:52:53 UTC) #8
Message was sent while issue was closed.
Change committed as 175734

Powered by Google App Engine
This is Rietveld 408576698