Issue 11820056: Delay consuming the mailbox in the resource provider until lockForRead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11820056: Delay consuming the mailbox in the resource provider until lockForRead. (Closed)

Created:
7 years, 11 months ago by alexst (slow to review)

Modified:
7 years, 11 months ago

Reviewers:
danakj, piman

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Delay consuming the mailbox in the resource provider until lockForRead. We don't need to consume the mailbox immediately after we receive it, since in UberComp case it causes unnecessary texture creation/deletion. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176435

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase, fix typo #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -17 lines)			Patch
	M	cc/resource_provider.cc	View	1	3 chunks	+19 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alexst (slow to review)

Followup optimization to the texture_layer mailbox change. I'll have another CL to cleanup typedefs and ...

7 years, 11 months ago (2013-01-10 19:42:35 UTC) #1

danakj

lgtm2 https://codereview.chromium.org/11820056/diff/1/cc/resource_provider.cc File cc/resource_provider.cc (right): https://codereview.chromium.org/11820056/diff/1/cc/resource_provider.cc#newcode247 cc/resource_provider.cc:247: // Just store the infomration. Mailbox will be ...

7 years, 11 months ago (2013-01-11 00:23:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexst@chromium.org/11820056/5001

7 years, 11 months ago (2013-01-11 17:38:18 UTC) #4

Message was sent while issue was closed.

Change committed as 176435

Expand Messages | Collapse Messages