Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 11820020: Removed few methods from CallbackHelper in drive_file_system_unittest.cc (Closed)

Created:
7 years, 11 months ago by peria
Modified:
7 years, 11 months ago
Reviewers:
yoshiki, satorux1
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removed following methods from CallbackHelper in drive_file_system_unittest.cc - FileOperationCallback - GetEntryInfoCallback BUG=141521 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176056

Patch Set 1 #

Patch Set 2 : Style fix #

Patch Set 3 : Remove GetEntryInfoCallback method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -122 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 1 2 24 chunks +101 lines, -122 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
peria
Satoru san, would you review this? Simply replaced two callback methods with existing functions in ...
7 years, 11 months ago (2013-01-10 03:01:18 UTC) #1
satorux1
LGTM. Thanks!
7 years, 11 months ago (2013-01-10 03:33:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/11820020/5001
7 years, 11 months ago (2013-01-10 03:40:36 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 12:53:04 UTC) #4
Message was sent while issue was closed.
Change committed as 176056

Powered by Google App Engine
This is Rietveld 408576698