Add app_list_unittests as a default builder target.

Add app_list_unittests as a default builder target.

Prior to this change, app_list_unittests was built only on aura targets.
However, the app list has been ported to Windows, and a mac port is
in progress. Once this change bakes, a trybot target will be added for
the builders in the tools repo. app_list_unittests is currently small and
quick (runs in <10 seconds).

BUG=138633
TEST=builders succeed their compile phase

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178260

[tapted, 2013-01-17 04:31:32]

@cmp: please take a look.

This is just adding the target to the compile phase. The end-goal is to include
a trybot target, which will be a follow-up CL (I'll use
http://crrev.com/11316278 as a guide). Want to ensure I'm not missing something
on this side.

Thanks.

[tapted, 2013-01-22 22:28:15]

@cmp: ping

(was hoping to pin you for the follow-up CL in the tools/build repo as well)

[cmp, 2013-01-22 23:29:24]

On 2013/01/22 22:28:15, tapted wrote:
> @cmp: ping
> 
> (was hoping to pin you for the follow-up CL in the tools/build repo as well)

Delegating to Robbie for both.  LMK if you have any follow-up questions.

[iannucci, 2013-01-23 00:19:53]

lgtm, with the possible exception that I'm not a fan of adding more build config
flags :/. Do you expect 'enable_app_list' to be short lived?

[tapted, 2013-01-23 01:33:05]

On 2013/01/23 00:19:53, iannucci wrote:
> lgtm, with the possible exception that I'm not a fan of adding more build
config
> flags :/. Do you expect 'enable_app_list' to be short lived?

enable_settings_app is essentially an alias for a set of platforms. It came up
in a prior review that there were too many OS_WIN || ... cropping up. The flag
is true by default on ChromeOS (and ash), Windows, and (recently) Mac. Linux is
also planned.

While the platforms are being phased in, the flag is helpful, although it will
never be part of android/ios builds.

But when all the desktop targets are implemented, yes, the flag could be phased
out in favour of (e.g.) !OS_IOS && !OS_ANDROID (or similar)

[iannucci, 2013-01-23 01:35:01]

On 2013/01/23 01:33:05, tapted wrote:
> On 2013/01/23 00:19:53, iannucci wrote:
> > lgtm, with the possible exception that I'm not a fan of adding more build
> config
> > flags :/. Do you expect 'enable_app_list' to be short lived?
> 
> enable_settings_app is essentially an alias for a set of platforms. It came up
> in a prior review that there were too many OS_WIN || ... cropping up. The flag
> is true by default on ChromeOS (and ash), Windows, and (recently) Mac. Linux
is
> also planned.
> 
> While the platforms are being phased in, the flag is helpful, although it will
> never be part of android/ios builds.
> 
> But when all the desktop targets are implemented, yes, the flag could be
phased
> out in favour of (e.g.) !OS_IOS && !OS_ANDROID (or similar)

Ok, that sounds good to me then. I looked through the rest of the gyp files and
yeah, it needs to be a flag :).

more lgtm :)

[commit-bot: I haz the power, 2013-01-23 01:55:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/11820019/18001

[commit-bot: I haz the power, 2013-01-23 04:32:39]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-01-23 05:25:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/11820019/18001

[commit-bot: I haz the power, 2013-01-23 06:08:17]

Change committed as 178260