Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: content/shell/webkit_test_controller.cc

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/webkit_test_controller.h ('k') | webkit/plugins/ppapi/plugin_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/webkit_test_controller.cc
diff --git a/content/shell/webkit_test_controller.cc b/content/shell/webkit_test_controller.cc
index af585b6c83ca742ba988f54d3b63e98ac0e6515f..97fd60b3e311cbb4928b09ea308d85422f1d5aa0 100644
--- a/content/shell/webkit_test_controller.cc
+++ b/content/shell/webkit_test_controller.cc
@@ -12,6 +12,7 @@
#include "base/process_util.h"
#include "base/run_loop.h"
#include "base/string_number_conversions.h"
+#include "base/stringprintf.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
@@ -266,9 +267,11 @@ bool WebKitTestController::OnMessageReceived(const IPC::Message& message) {
return handled;
}
-void WebKitTestController::PluginCrashed(const FilePath& plugin_path) {
+void WebKitTestController::PluginCrashed(const FilePath& plugin_path,
+ base::ProcessId plugin_pid) {
DCHECK(CalledOnValidThread());
- printer_->AddErrorMessage("#CRASHED - plugin");
+ printer_->AddErrorMessage(
+ base::StringPrintf("#CRASHED - plugin (pid %d)", plugin_pid));
}
void WebKitTestController::RenderViewCreated(RenderViewHost* render_view_host) {
« no previous file with comments | « content/shell/webkit_test_controller.h ('k') | webkit/plugins/ppapi/plugin_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698