Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2521)

Unified Diff: content/renderer/webplugin_delegate_proxy.cc

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/shell/webkit_test_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/webplugin_delegate_proxy.cc
diff --git a/content/renderer/webplugin_delegate_proxy.cc b/content/renderer/webplugin_delegate_proxy.cc
index 09f989b9abade65f015724927c1be9f39fcf6c62..7b590a5dc02ca350a890b66220e37e76f033b60d 100644
--- a/content/renderer/webplugin_delegate_proxy.cc
+++ b/content/renderer/webplugin_delegate_proxy.cc
@@ -316,7 +316,7 @@ bool WebPluginDelegateProxy::Initialize(
// shouldn't happen, since if we got here the plugin should exist) or the
// plugin crashed on initialization.
if (!info_.path.empty()) {
- render_view_->PluginCrashed(info_.path);
+ render_view_->PluginCrashed(info_.path, base::kNullProcessId);
LOG(ERROR) << "Plug-in crashed on start";
// Return true so that the plugin widget is created and we can paint the
@@ -499,7 +499,7 @@ void WebPluginDelegateProxy::OnChannelError() {
plugin_->Invalidate();
}
if (!channel_host_->expecting_shutdown())
- render_view_->PluginCrashed(info_.path);
+ render_view_->PluginCrashed(info_.path, channel_host_->peer_pid());
#if defined(OS_MACOSX) || defined(OS_WIN)
// Ensure that the renderer doesn't think the plugin still has focus.
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/shell/webkit_test_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698