Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/pepper/pepper_plugin_delegate_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index c3b1a9493945d3e5057da6077130ad37feee2d80..77e2c05158071f1b4c5c0a547e3248557008cfa1 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -5,6 +5,7 @@
#ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
#define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
+#include "base/process.h"
#include "base/process_util.h"
#include "content/common/content_export.h"
#include "content/public/browser/navigation_controller.h"
@@ -109,7 +110,12 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
bool blocked_by_policy) {}
// Notification that a plugin has crashed.
- virtual void PluginCrashed(const FilePath& plugin_path) {}
+ // |plugin_pid| is the process ID identifying the plugin process. Note that
+ // this ID is supplied by the renderer, so should not be trusted. Besides, the
+ // corresponding process has probably died at this point. The ID may even have
+ // been reused by a new process.
+ virtual void PluginCrashed(const FilePath& plugin_path,
+ base::ProcessId plugin_pid) {}
// Notication that the given plugin has hung or become unhung. This
// notification is only for Pepper plugins.
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/pepper/pepper_plugin_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698