Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 11819045: Skips testActivateTab on old browsers which don't support tab control. (Closed)

Created:
7 years, 11 months ago by Danh Nguyen
Modified:
7 years, 11 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

Skips testActivateTab on old browsers which don't support tab control. BUG=168984 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/telemetry/telemetry/tab.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/tab_unittest.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Danh Nguyen
Hi Nat & Dave, This is to fix failures of testActivateTab() on old browsers. I've ...
7 years, 11 months ago (2013-01-09 22:33:17 UTC) #1
nduca
lgtm
7 years, 11 months ago (2013-01-09 23:02:18 UTC) #2
Danh Nguyen
On 2013/01/09 23:02:18, nduca wrote: > lgtm Thanks, Nat. Danh
7 years, 11 months ago (2013-01-10 16:25:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danhn@chromium.org/11819045/1
7 years, 11 months ago (2013-01-10 16:26:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-10 16:41:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danhn@chromium.org/11819045/1
7 years, 11 months ago (2013-01-10 16:59:37 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 20:10:25 UTC) #7
Message was sent while issue was closed.
Change committed as 176136

Powered by Google App Engine
This is Rietveld 408576698