Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: ipc/ipc_test_base.h

Issue 11819041: Make ipc_tests file structure a little saner and add an ipc_perftests target. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ugh Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_send_fds_test.cc ('k') | ipc/ipc_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_test_base.h
diff --git a/ipc/ipc_tests.h b/ipc/ipc_test_base.h
similarity index 60%
rename from ipc/ipc_tests.h
rename to ipc/ipc_test_base.h
index 76d274ca47c0ff77597de76e4cba12beada597ea..08d410ce518d32101cf52c0101439b213b5a0740 100644
--- a/ipc/ipc_tests.h
+++ b/ipc/ipc_test_base.h
@@ -2,22 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef IPC_IPC_TESTS_H_
-#define IPC_IPC_TESTS_H_
+#ifndef IPC_IPC_TEST_BASE_H_
+#define IPC_IPC_TEST_BASE_H_
-#include "base/test/multiprocess_test.h"
#include "base/process.h"
-
-// This unit test uses 3 types of child processes, a regular pipe client,
-// a client reflector and a IPC server used for fuzzing tests.
-enum ChildType {
- TEST_CLIENT,
- TEST_DESCRIPTOR_CLIENT,
- TEST_DESCRIPTOR_CLIENT_SANDBOXED,
- TEST_REFLECTOR,
- FUZZER_SERVER,
- SYNC_SOCKET_SERVER
-};
+#include "base/test/multiprocess_test.h"
// The different channel names for the child processes.
extern const char kTestClientChannel[];
@@ -30,11 +19,20 @@ namespace IPC {
class Channel;
} // namespace IPC
-//Base class to facilitate Spawning IPC Client processes.
-class IPCChannelTest : public base::MultiProcessTest {
- protected:
+// Base class to facilitate spawning IPC client processes.
+class IPCTestBase : public base::MultiProcessTest {
+ public:
+ enum ChildType {
+ TEST_CLIENT,
+ TEST_DESCRIPTOR_CLIENT,
+ TEST_DESCRIPTOR_CLIENT_SANDBOXED,
+ TEST_REFLECTOR,
+ FUZZER_SERVER,
+ SYNC_SOCKET_SERVER
+ };
- // Create a new MessageLoopForIO For each test.
+ protected:
+ // Create a new MessageLoopForIO for each test.
virtual void SetUp() OVERRIDE;
virtual void TearDown() OVERRIDE;
@@ -45,4 +43,4 @@ class IPCChannelTest : public base::MultiProcessTest {
MessageLoopForIO* message_loop_;
};
-#endif // IPC_IPC_TESTS_H_
+#endif // IPC_IPC_TEST_BASE_H_
« no previous file with comments | « ipc/ipc_send_fds_test.cc ('k') | ipc/ipc_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698