Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 11819035: Adjust fonts (part of 137349): use standard font sizes in AvatarMenuBubble (Closed)

Created:
7 years, 11 months ago by sschmitz
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adjust fonts (part of 137349): use standard font sizes in chrome/browser/ui/views/avatar_menu_bubble_view.cc This is for Chrome on Windows. Part of work to use standard font sizes instead of "DeriveFont +/- N Pixels". Changed UIs were seen and blessed by sgabriel@ and kuscher@. The code now uses standard fonts: base and small. Base is used for the names. The resulting change is: Old: 13 pixels (bold for active, non-bold otherwise) New: 12 pixels (... same bolding) For the emails the font size did not change, since the std SmallFont was recently changed from 10 to 11 pixels. Please see crbug.com/169039 for before and after screenshots BUG=169039, 137349 TEST=manual Bring up Chrome on windows; click on avatar in top bar. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sschmitz
I hope this is the last CL of the "Adjust font" series. This is very ...
7 years, 11 months ago (2013-01-09 19:10:48 UTC) #1
sky
LGTM
7 years, 11 months ago (2013-01-09 20:40:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/11819035/1
7 years, 11 months ago (2013-01-09 21:15:54 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 00:03:34 UTC) #4
Message was sent while issue was closed.
Change committed as 175932

Powered by Google App Engine
This is Rietveld 408576698