|
|
Refactors building the system menu model into a common place
(SystemMenuModelBuilder) and makes BrowserFrame implementation use
it. BrowserFrame also provides support for showing the system menu via
views::MenuRunner. This is used everywhere but BrowserFrameWin and
BrowserDesktolpRootWindowHostWin. Both of these use the system menu.
BUG=none
TEST=make sure system menu (right click above tab strip) works on
windows and chromeos.
R=ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175849
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+310 lines, -178 lines) |
Patch |
 |
M |
chrome/browser/ui/browser.h
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_desktop_root_window_host.h
|
View
|
1
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_desktop_root_window_host_linux.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_desktop_root_window_host_linux.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.h
|
View
|
|
3 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.cc
|
View
|
|
4 chunks |
+25 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame.h
|
View
|
|
6 chunks |
+20 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame.cc
|
View
|
1
2
|
3 chunks |
+37 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame_aura.h
|
View
|
|
4 chunks |
+2 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame_aura.cc
|
View
|
|
4 chunks |
+2 lines, -41 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame_win.h
|
View
|
|
4 chunks |
+3 lines, -17 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/browser_frame_win.cc
|
View
|
1
2
|
6 chunks |
+14 lines, -78 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/desktop_browser_frame_aura.h
|
View
|
|
3 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc
|
View
|
|
3 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/native_browser_frame.h
|
View
|
1
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
A |
chrome/browser/ui/views/frame/system_menu_model_builder.h
|
View
|
1
2
|
1 chunk |
+58 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/ui/views/frame/system_menu_model_builder.cc
|
View
|
1
2
|
1 chunk |
+111 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/frame/system_menu_model_delegate.h
|
View
|
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_browser_ui.gypi
|
View
|
1
2
|
3 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
ui/views/views.gyp
|
View
|
1
2
|
2 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
Total messages: 6 (0 generated)
|
Chromium Code Reviews
Issue
11819008:
Refactors building the system menu model into a common place (Closed)
