Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 11819002: Android: fixes missing semi-colon in inner classes for jni_generator. (Closed)

Created:
7 years, 11 months ago by bulach
Modified:
7 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Android: fixes missing semi-colon in inner classes for jni_generator. Qualified classes require a semi-colon in the end. BUG= TEST=jni_generator_tests.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/android/jni_generator/jni_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
7 years, 11 months ago (2013-01-08 19:47:48 UTC) #1
Leandro Graciá Gil
LGTM. Locally tested to work. Thanks!
7 years, 11 months ago (2013-01-08 19:49:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11819002/1
7 years, 11 months ago (2013-01-09 10:05:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) content_browsertests
7 years, 11 months ago (2013-01-09 12:49:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11819002/1
7 years, 11 months ago (2013-01-09 12:50:20 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 13:50:06 UTC) #6
Message was sent while issue was closed.
Change committed as 175795

Powered by Google App Engine
This is Rietveld 408576698