Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: chrome/test/webdriver/webdriver_session.cc

Issue 11818029: [chromedriver] Remove support for simulating OS-level key events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/webdriver_session.cc
diff --git a/chrome/test/webdriver/webdriver_session.cc b/chrome/test/webdriver/webdriver_session.cc
index 55a37f6289a64c0c8308dba72fc0ceb8ebe0e258..55d718e8dea902c3ce77b1a0588aea258266f798 100644
--- a/chrome/test/webdriver/webdriver_session.cc
+++ b/chrome/test/webdriver/webdriver_session.cc
@@ -1538,22 +1538,9 @@ void Session::SendKeysOnSessionThread(const string16& keys,
return;
}
for (size_t i = 0; i < key_events.size(); ++i) {
- if (capabilities_.native_events) {
- // The automation provider will generate up/down events for us, we
- // only need to call it once as compared to the WebKeyEvent method.
- // Hence we filter events by their types, keeping only rawkeydown.
- if (key_events[i].type != automation::kRawKeyDownType)
- continue;
- automation_->SendNativeKeyEvent(
- current_target_.view_id,
- key_events[i].key_code,
- key_events[i].modifiers,
- error);
- } else {
- automation_->SendWebKeyEvent(
- current_target_.view_id,
- key_events[i], error);
- }
+ automation_->SendWebKeyEvent(
+ current_target_.view_id,
+ key_events[i], error);
if (*error) {
std::string details = base::StringPrintf(
"Failed to send key event. Event details:\n"
« no previous file with comments | « chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698