Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 11818029: [chromedriver] Remove support for simulating OS-level key events. (Closed)

Created:
7 years, 11 months ago by kkania
Modified:
7 years, 11 months ago
Reviewers:
craigdh
CC:
chromium-reviews, kkania, chrisgao (Use stgao instead), jam
Visibility:
Public.

Description

[chromedriver] Remove support for simulating OS-level key events. This was added awhile back particularly for testing with IMEs. Simulating these events is done in the browser, but that support is going away soon. We could switch to simulating these events in ChromeDriver itself, but I don't see a strong case for doing so right now, so we're dropping support. If the user attempts to set chrome.nativeEvents to true, they will receive an error. We ignore the normal nativeEvents capability and always report to the user that we are using native events, since the normal way we simulate events is close enough to OS-level events. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175909

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -83 lines) Patch
M chrome/test/webdriver/commands/session_with_id.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/webdriver/test/chromedriver_tests.py View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/test/webdriver/webdriver_automation.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/webdriver/webdriver_automation.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/test/webdriver/webdriver_capabilities_parser.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/webdriver/webdriver_capabilities_parser.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/webdriver/webdriver_session.cc View 1 chunk +3 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kkania
7 years, 11 months ago (2013-01-09 16:56:42 UTC) #1
craigdh
lgtm.
7 years, 11 months ago (2013-01-09 18:49:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/11818029/1008
7 years, 11 months ago (2013-01-09 18:55:50 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-09 19:25:49 UTC) #4
kkania
7 years, 11 months ago (2013-01-09 20:29:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/11818029/5005
7 years, 11 months ago (2013-01-09 20:39:56 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 23:07:56 UTC) #7
Message was sent while issue was closed.
Change committed as 175909

Powered by Google App Engine
This is Rietveld 408576698