chrome/browser/extensions/api/alarms/alarm_manager.h - Issue 11818010: Make chrome.alarms API accept non-integers and too-short delays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/alarms/alarm_manager.h

Issue 11818010: Make chrome.alarms API accept non-integers and too-short delays. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: After discussion, switch to 1-minute minimum alarm time Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/alarms/alarm_manager.h

diff --git a/chrome/browser/extensions/api/alarms/alarm_manager.h b/chrome/browser/extensions/api/alarms/alarm_manager.h

index a5402ae6db8077328926d69450a3cad46e64f5d1..0854a041c7a5ed45063657374a69c4ae2f20e0dc 100644

--- a/chrome/browser/extensions/api/alarms/alarm_manager.h

+++ b/chrome/browser/extensions/api/alarms/alarm_manager.h

@@ -123,8 +123,8 @@ class AlarmManager

scoped_ptr<base::Value> value);

// Schedules the next poll of alarms for when the next soonest alarm runs,

- // but do not more often than min_period.

- void ScheduleNextPoll(base::TimeDelta min_period);

+ // but not more often than the minimum granularity of all alarms.

+ void ScheduleNextPoll();

// Polls the alarms, running any that have elapsed. After running them and

// rescheduling repeating alarms, schedule the next poll.