Make chrome.alarms API accept non-integers and too-short delays.

Make chrome.alarms API accept non-integers and too-short delays, and lower the minimum.

We still don't honor the too-short delays (this CL actually makes us
more aggressive about not honoring them), but I've lowered the limit
to 1 minute, and we emit a warning to the console instead of erroring,
and we emit this warning even in dev mode since people were getting
surprised by the difference in behavior between dev and release.

I've also moved the frequency description into the create()
documentation from the chrome.alarms summary, at joemarini's request.

And I fixed the eventPages example to work with trunk Chrome.

BUG=168519, 159879
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176004

[Yoyo Zhou, 2013-01-09 00:38:00]

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/alarms/alarms_api.cc (right):

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/alarms/alarms_api.cc:26: const int
kReleaseDelayMinimum = 5;
Per crbug.com/153838 the minimum was changed from 5 minutes to 1 minute (that's
why you see the 1 minute in alarm_manager). I don't know if that's still
necessary though (there were other bugs in Gmail checker that had to be fixed),
and since it didn't touch this, it may not have actually done anything =/.

Matt, any thoughts?

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/alarms/alarms_api.cc:62: " The alarm will fire in
approximately 5 minutes.");
Alarms have names - can we include those in the warning message?

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/alarms.idl (right):

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/common/extensio...
chrome/common/extensions/api/alarms.idl:58: // and cause a warning. 
<code>$ref:[alarms.AlarmCreateInfo.when
will cause

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/common/extensio...
chrome/common/extensions/api/alarms.idl:60: // warning but won't actually cause
the alarm to run for at least 5 minutes.
s/run/fire/

[Matt Perry, 2013-01-09 00:58:00]

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/alarms/alarms_api.cc (right):

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/alarms/alarms_api.cc:26: const int
kReleaseDelayMinimum = 5;
On 2013/01/09 00:38:00, Yoyo Zhou wrote:
> Per crbug.com/153838 the minimum was changed from 5 minutes to 1 minute
(that's
> why you see the 1 minute in alarm_manager). I don't know if that's still
> necessary though (there were other bugs in Gmail checker that had to be
fixed),
> and since it didn't touch this, it may not have actually done anything =/.
> 
> Matt, any thoughts?

Ah, I forgot we had that bug. It looks like it wasn't fixed. Let's update the
minimum to 1.

[Jeffrey Yasskin, 2013-01-09 01:04:45]

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/alarms/alarms_api.cc (right):

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/alarms/alarms_api.cc:26: const int
kReleaseDelayMinimum = 5;
On 2013/01/09 00:38:00, Yoyo Zhou wrote:
> Per crbug.com/153838 the minimum was changed from 5 minutes to 1 minute
(that's
> why you see the 1 minute in alarm_manager). I don't know if that's still
> necessary though (there were other bugs in Gmail checker that had to be
fixed),
> and since it didn't touch this, it may not have actually done anything =/.

It probably changed the first poll time but not later polls. Since the gmail
checker reschedules its alarm each time it fires, the granularity wasn't getting
enforced.

... Hm, actually the gmail checker uses a poll interval of 5 minutes, at least,
so it won't be affected by this change.

Other extensions that were using 'when' to get around the limit might be
affected, but they really shouldn't be waking up the event page that often
anyway.

> Matt, any thoughts?

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/alarms/alarms_api.cc:62: " The alarm will fire in
approximately 5 minutes.");
On 2013/01/09 00:38:00, Yoyo Zhou wrote:
> Alarms have names - can we include those in the warning message?

Done.

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/alarms.idl (right):

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/common/extensio...
chrome/common/extensions/api/alarms.idl:58: // and cause a warning. 
<code>$ref:[alarms.AlarmCreateInfo.when
On 2013/01/09 00:38:00, Yoyo Zhou wrote:
> will cause

Done.

https://chromiumcodereview.appspot.com/11818010/diff/1/chrome/common/extensio...
chrome/common/extensions/api/alarms.idl:60: // warning but won't actually cause
the alarm to run for at least 5 minutes.
On 2013/01/09 00:38:00, Yoyo Zhou wrote:
> s/run/fire/

Done.

[Jeffrey Yasskin, 2013-01-09 19:38:20]

After discussion with Matt and Yoyo, I've switched this CL to allowing 1-minute
alarm delays.

[Yoyo Zhou, 2013-01-09 19:41:49]

LGTM

[commit-bot: I haz the power, 2013-01-09 19:53:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/11818010/8001

[commit-bot: I haz the power, 2013-01-10 02:59:46]

Change committed as 176004

[Matt Perry, 2013-04-05 23:24:26]

https://chromiumcodereview.appspot.com/11818010/diff/8001/chrome/browser/exte...
File chrome/browser/extensions/api/alarms/alarm_manager.cc (right):

https://chromiumcodereview.appspot.com/11818010/diff/8001/chrome/browser/exte...
chrome/browser/extensions/api/alarms/alarm_manager.cc:32: const base::TimeDelta
kDefaultMinPollPeriod = base::TimeDelta::FromDays(1);
Did you mean to change this to days?

[Jeffrey Yasskin, 2013-04-08 08:56:37]

https://chromiumcodereview.appspot.com/11818010/diff/8001/chrome/browser/exte...
File chrome/browser/extensions/api/alarms/alarm_manager.cc (right):

https://chromiumcodereview.appspot.com/11818010/diff/8001/chrome/browser/exte...
chrome/browser/extensions/api/alarms/alarm_manager.cc:32: const base::TimeDelta
kDefaultMinPollPeriod = base::TimeDelta::FromDays(1);
On 2013/04/05 23:24:26, Matt Perry wrote:
> Did you mean to change this to days?

Yes, because line 264 reduces the actual value used to the minimum granularity
of any alarm. Alarm granularities are set at
https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ex....