chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm - Issue 11817045: Move auth-error reporting code out of SyncGlobalError and into SigninGlobalError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

Issue 11817045: Move auth-error reporting code out of SyncGlobalError and into SigninGlobalError (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Disabled ExtensionActionContextMenuTest.BrowserAction Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

index 8e6e501788758e9915f3243493fb1d79f56606cf..9854e7ef443457dc6a3c99975370fb9888cd24de 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

@@ -88,7 +88,10 @@ IN_PROC_BROWSER_TEST_F(ExtensionActionContextMenuTest, BasicTest) {

// Test that browser action context menus work. Browser actions have their

// menus created during browser initialization, when there is no tab. This

// test simulates that and checks the menu is operational.

-IN_PROC_BROWSER_TEST_F(ExtensionActionContextMenuTest, BrowserAction) {

+// TODO(atwilson): Re-enable this test with a change to free the browser

+// properly in a way that does not leave dangling references in the

+// ToolbarController.

+IN_PROC_BROWSER_TEST_F(ExtensionActionContextMenuTest, DISABLED_BrowserAction) {

extension_ = InstallExtension(

test_data_dir_.AppendASCII("browsertest")

.AppendASCII("browser_action_popup"),

« no previous file with comments | « chrome/browser/sync/sync_ui_util_unittest.cc ('k') | chrome/browser/ui/toolbar/wrench_menu_model.h » ('j') | no next file with comments »