Enable shared memory handle sharing in NaCl.

Enable shared memory handle sharing in NaCl.

The destructor for base::SharedMemory closes its handle on destruction.
To keep a shared memory region alive after using it, we need to
duplicate the handle. This uses dup(), which is available in native
client.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176133

[bbudge, 2013-01-09 18:18:42]

https://codereview.chromium.org/11817020/diff/1/base/shared_memory_nacl.cc
File base/shared_memory_nacl.cc (right):

https://codereview.chromium.org/11817020/diff/1/base/shared_memory_nacl.cc#ne...
base/shared_memory_nacl.cc:142: return false;
Should we log the error here, as in shared_memory_posix.cc?
    DPLOG(ERROR) << "dup() failed.";

[teravest, 2013-01-09 19:13:15]

https://codereview.chromium.org/11817020/diff/1/base/shared_memory_nacl.cc
File base/shared_memory_nacl.cc (right):

https://codereview.chromium.org/11817020/diff/1/base/shared_memory_nacl.cc#ne...
base/shared_memory_nacl.cc:142: return false;
On 2013/01/09 18:18:42, bbudge1 wrote:
> Should we log the error here, as in shared_memory_posix.cc?
>     DPLOG(ERROR) << "dup() failed.";

Done.

[bbudge, 2013-01-09 20:13:00]

lgtm

[brettw, 2013-01-09 21:01:05]

LGTM. It's a bit unfortunate how much code duplication there is between this and
the posix one. I wonder if we can find a way to improve this without making a
mess. I notice Android uses the _posix file plus its own, which might be
something to consider as long as it doesn't require too many ifdefs in the
common one.

[commit-bot: I haz the power, 2013-01-10 17:21:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/11817020/5001

[commit-bot: I haz the power, 2013-01-10 20:00:48]

Change committed as 176133