Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 11817016: Delete unused kDisableDesktopShortcuts switch. (Closed)

Created:
7 years, 11 months ago by Alexei Svitkine (slow)
Modified:
7 years, 11 months ago
Reviewers:
sail
CC:
chromium-reviews
Visibility:
Public.

Description

Delete unused kDisableDesktopShortcuts switch. I don't think we need to support such a switch because: 1. Shortcut creation is already controlled by a checkbox in the UI. 2. Profile creation should be sufficiently rare that it doesn't make sense to have a switch to control this. BUG=none TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
7 years, 11 months ago (2013-01-09 15:41:27 UTC) #1
sail
lgtm
7 years, 11 months ago (2013-01-09 20:18:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11817016/1
7 years, 11 months ago (2013-01-09 20:35:52 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-09 20:45:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11817016/1
7 years, 11 months ago (2013-01-09 20:48:23 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 00:08:49 UTC) #6
Message was sent while issue was closed.
Change committed as 175935

Powered by Google App Engine
This is Rietveld 408576698