Add base_url to DriveApiUrlGenerator.

Add base_url to DriveApiUrlGenerator.

This is preparation for injecting server path to the drive api operations.
Its main usage is injecting local test server for unittests of classes in
drive_api_operations.{cc, h} (will be done in following CLs).
To share the testing utility GetBaseUrlForTesting, it is moved into test_util.

BUG=162155
TEST=Ran unit_tests and chromeos_unittests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175774

[hidehiko, 2013-01-08 15:43:48]

Thank you for your review in advance,
- hidehiko

[satorux1, 2013-01-09 00:19:53]

https://codereview.chromium.org/11804004/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_system_service.cc (right):

https://codereview.chromium.org/11804004/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_system_service.cc:127: GURL(),
Empty URL looks cryptic. See below for what we do with GDataWapiUrlGenerator:

GURL(google_apis::GDataWapiUrlGenerator::kBaseUrlForProduction),

https://codereview.chromium.org/11804004/diff/1/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_api_url_generator.h (right):

https://codereview.chromium.org/11804004/diff/1/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_url_generator.h:19: // If empty, the
default production server is used.
Let's not use the empty URL.

[hidehiko, 2013-01-09 04:47:36]

Could you take another look?

https://codereview.chromium.org/11804004/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_system_service.cc (right):

https://codereview.chromium.org/11804004/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_system_service.cc:127: GURL(),
On 2013/01/09 00:19:53, satorux1 wrote:
> Empty URL looks cryptic. See below for what we do with GDataWapiUrlGenerator:
> 
> GURL(google_apis::GDataWapiUrlGenerator::kBaseUrlForProduction),

Done.

https://codereview.chromium.org/11804004/diff/1/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_api_url_generator.h (right):

https://codereview.chromium.org/11804004/diff/1/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_url_generator.h:19: // If empty, the
default production server is used.
On 2013/01/09 00:19:53, satorux1 wrote:
> Let's not use the empty URL.

Done.

[satorux1, 2013-01-09 04:49:11]

LGTM

[kinaba, 2013-01-09 05:12:51]

lgtm

[commit-bot: I haz the power, 2013-01-09 05:20:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/11804004/6001

[commit-bot: I haz the power, 2013-01-09 09:00:31]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-09 09:05:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/11804004/6001

[commit-bot: I haz the power, 2013-01-09 10:56:12]

Change committed as 175774