Issue 11801027: More work to make ash_unittests pass when we require context.

Issue 11801027: More work to make ash_unittests pass when we require context. (Closed)

Created:
7 years, 11 months ago by Elliot Glaysher

Modified:
7 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

More work to make ash_unittests pass when we require context. With the context checking DCHECK, ash_unittests and unit_tests now run on chromeos. BUG=161882 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175892

Patch Set 1 #

Patch Set 2 : It looks like ash_unittests passes now. #

Patch Set 3 : Clean up most remainging CreateWindowWithBounds() calls #

Patch Set 4 : Rebase to ToT #

Patch Set 5 : Fix ridiculous spelling error. #

Patch Set 6 : Remove DCHECK for commit. #

Patch Set 7 : Possible asan fix. #

Total comments: 2

Patch Set 8 : Try to fix the win_rel failure, which looks real. #

Patch Set 9 : Fix TableViewTest by making it a ViewsTestBase. #

Patch Set 10 : Fix TableViewTest by making it a ViewsTestBase. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -35 lines)			Patch
M	ash/accelerators/accelerator_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/drag_drop/drag_drop_controller.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/drag_drop/drag_image_view.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/drag_drop/drag_image_view.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	ash/launcher/launcher_tooltip_manager_unittest.cc	View	1 2 3 4 5 6	4 chunks	+21 lines, -2 lines	0 comments	Download
M	ash/launcher/launcher_view_unittest.cc	View		6 chunks	+20 lines, -0 lines	0 comments	Download
M	ash/shell/widgets.cc	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	ash/shell/window_type_launcher.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/native_app_window_views.cc	View	1 2 3 4 5 6 7 8	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/oak/oak.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/oak/oak_window.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	ui/views/controls/table/table_view_unittest.cc	View	1 2 3 4 5 6 7 8	3 chunks	+10 lines, -9 lines	0 comments	Download
M	ui/views/test/views_test_base.h	View	1 2 3 4 5 6 7 8	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/test/views_test_base.cc	View	1 2 3 4 5 6 7 8	1 chunk	+8 lines, -0 lines	0 comments	Download
M	ui/views/widget/widget.h	View	1 2	1 chunk	+11 lines, -3 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	1 2 3 4 5 6 7	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm https://codereview.chromium.org/11801027/diff/37016/ash/drag_drop/drag_image_view.h File ash/drag_drop/drag_image_view.h (right): https://codereview.chromium.org/11801027/diff/37016/ash/drag_drop/drag_image_view.h#newcode19 ash/drag_drop/drag_image_view.h:19: DragImageView(gfx::NativeView context); explicit https://codereview.chromium.org/11801027/diff/37016/ui/views/widget/widget.h File ui/views/widget/widget.h (right): https://codereview.chromium.org/11801027/diff/37016/ui/views/widget/widget.h#newcode217 ...

7 years, 11 months ago (2013-01-09 17:30:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/11801027/25023

7 years, 11 months ago (2013-01-09 19:23:05 UTC) #3

Message was sent while issue was closed.

Change committed as 175892

Expand Messages | Collapse Messages