Issue 11801018: Fix small error in SimpleMock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11801018: Fix small error in SimpleMock. (Closed)

Created:
7 years, 11 months ago by M-A Ruel

Modified:
7 years, 11 months ago

Reviewers:
cmp

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Fix small error in SimpleMock. It's bad python practice to use a class-level member that is mutable. self.calls is already initialized in __init__ so it's not useful (and dangerous) to have it as a class member. R=cmp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=175368

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	testing_support/auto_stub.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/11801018/1

7 years, 11 months ago (2013-01-07 19:02:51 UTC) #3

Message was sent while issue was closed.

Change committed as 175368