Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 11801014: Switch WebUITestHandler to use ExecuteJavascriptInWebFrameCallbackResult. (Closed)

Created:
7 years, 11 months ago by Avi (use Gerrit)
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Switch WebUITestHandler to use ExecuteJavascriptInWebFrameCallbackResult. BUG=168169 TEST=should all pass Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175426

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M chrome/browser/ui/webui/web_ui_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_test_handler.h View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_test_handler.cc View 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
7 years, 11 months ago (2013-01-07 19:44:01 UTC) #1
jam
lgtm
7 years, 11 months ago (2013-01-07 20:14:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11801014/5027
7 years, 11 months ago (2013-01-07 20:29:33 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 00:26:48 UTC) #4
Message was sent while issue was closed.
Change committed as 175426

Powered by Google App Engine
This is Rietveld 408576698