Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 11801007: Make getBranchForMilestone() explictly request the CSV data. (Closed)

Created:
7 years, 11 months ago by Philippe
Modified:
7 years, 11 months ago
Reviewers:
James Hawkins, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, pasko-google - do not use
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools@master
Visibility:
Public.

Description

Make getBranchForMilestone() explictly request the CSV data. This fixes the following crash: Traceback (most recent call last): File "/usr/local/google/home/pliard/ssd/depot_tools/drover.py", line 682, in <module> sys.exit(main()) File "/usr/local/google/home/pliard/ssd/depot_tools/drover.py", line 678, in main return drover(options, args) File "/usr/local/google/home/pliard/ssd/depot_tools/drover.py", line 493, in drover options.branch = getBranchForMilestone(options.milestone) File "/usr/local/google/home/pliard/ssd/depot_tools/drover.py", line 393, in getBranchForMilestone version = string.split(parameters[2], '.') IndexError: list index out of range Sending crash report ... args: ['/usr/local/google/home/pliard/ssd/depot_tools/drover.py', '--merge', '175139', '--milestone', '25'] cwd: /mnt/ssd/pliard/chromium/src/drover exception: list index out of range host: vox.par.corp.google.com stack: File "/usr/local/google/home/pliard/ssd/depot_to user: pliard version: 2.7.3 (default, Aug 1 2012, 05:14:39) [GCC 4.6.3 This function is called when the --milestone switch is provided. It requests omahaproxy to fetch the branch corresponding to the provided milestone. This function expects some CSV data coming from omahaproxy although it appeared to actually receive the same HTML data that a browser receives when requesting http://omahaproxy.appspot.com (user agent issue?). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=175337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M drover.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Philippe
Hi James, I had to use drover for the first time and came across this ...
7 years, 11 months ago (2013-01-07 11:36:43 UTC) #1
M-A Ruel
lgtm
7 years, 11 months ago (2013-01-07 14:47:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/11801007/1
7 years, 11 months ago (2013-01-07 15:34:43 UTC) #3
commit-bot: I haz the power
Change committed as 175337
7 years, 11 months ago (2013-01-07 15:37:15 UTC) #4
Philippe
7 years, 11 months ago (2013-01-07 15:38:51 UTC) #5
Message was sent while issue was closed.
On 2013/01/07 15:37:15, I haz the power (commit-bot) wrote:
> Change committed as 175337

Thanks for committing Marc-Antoine. This was quick :)

Powered by Google App Engine
This is Rietveld 408576698