Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 11797004: Move iframe@seamless behind the "Experimental WebKit Features" flag. (Closed)

Created:
7 years, 11 months ago by Mike West
Modified:
7 years, 11 months ago
Reviewers:
jamesr, eseidel1
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move iframe@seamless behind the "Experimental WebKit Features" flag. Previously, seamless was compile-time enabled via WebKit's ENABLE_IFRAME_SEAMLESS flag. wkrev.com/138983 added a runtime component to enable the feature. This patch implements the Chromium side of that change. Until we're happy with the state of the feature, it will be hidden behind the "Experimental WebKit Features" flag, which can be enabled via `about:flags` for experimentation. Among other benefits, this means that we won't forget to turn it off before each stable release rolls out the door. BUG=168558 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/renderer/render_thread_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Hi Eric! Would you mind taking a look at the Chromium side of https://bugs.webkit.org/show_bug.cgi?id=106213, which ...
7 years, 11 months ago (2013-01-08 14:42:04 UTC) #1
jamesr
lgtm if Eric's happy enough with the state of this feature to turn it on ...
7 years, 11 months ago (2013-01-08 23:24:36 UTC) #2
eseidel1
LGTM. The feature almost ended up on in M24. From chatting with Hyatt, I suspect ...
7 years, 11 months ago (2013-01-08 23:38:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/11797004/1
7 years, 11 months ago (2013-01-09 06:58:56 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 08:47:54 UTC) #5
Message was sent while issue was closed.
Change committed as 175747

Powered by Google App Engine
This is Rietveld 408576698