Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11796003: Remove RenderWidget::WebWidgetHandlesCompositorScheduling (Closed)

Created:
7 years, 11 months ago by jamesr
Modified:
7 years, 11 months ago
Reviewers:
nduca
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove RenderWidget::WebWidgetHandlesCompositorScheduling WebKit::WebWidget isn't directly involved in compositor scheduling any more (due to https://codereview.chromium.org/11575049/). Instead of checking that bit and going to WebWidget, RenderWidget can either self-schedule or go directly to the WebLayerTreeView. BUG=156175 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178747

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : check for web_layer_tree_view_ in scheduleComposite since RenderWidgetFullscreenPepper is composite… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M content/renderer/render_view_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M content/renderer/render_widget.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
With this and https://codereview.chromium.org/11787006/, WebWidget::composite() can go away completely.
7 years, 11 months ago (2013-01-04 22:58:55 UTC) #1
nduca
lgtm
7 years, 11 months ago (2013-01-05 03:42:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11796003/5001
7 years, 11 months ago (2013-01-25 01:38:53 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on mac_rel HTTP Error 400: Bad Request
7 years, 11 months ago (2013-01-25 02:27:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11796003/14002
7 years, 11 months ago (2013-01-25 02:27:12 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 04:38:28 UTC) #6
Message was sent while issue was closed. 
Change committed as 178747

Powered by Google App Engine
This is Rietveld 408576698