Incrementally make base histograms like UMA histograms.

Incrementally make base histograms like UMA histograms.

Over in related https://codereview.chromium.org/11649028/ , I had to add HISTOGRAM_BOOLEAN. It's not right that UMA_HISTOGRAM_* and HISTOGRAM_* are not the same. This CL doesn't fix that, but it does at least make things less bad.

R=isherman@chromium.org
BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175658

[gavinp, 2013-01-07 03:59:05]

Ilya, WDYT?

https://codereview.chromium.org/11794020/diff/1/base/metrics/histogram.h
File base/metrics/histogram.h (left):

https://codereview.chromium.org/11794020/diff/1/base/metrics/histogram.h#oldc...
base/metrics/histogram.h:188: // For folks that need real specific times, use
this to select a precise range
This move makes this part of the code more parallel to the UMA_* section.

[Ilya Sherman, 2013-01-07 22:52:22]

https://codereview.chromium.org/11794020/diff/1/base/metrics/histogram.h
File base/metrics/histogram.h (right):

https://codereview.chromium.org/11794020/diff/1/base/metrics/histogram.h#newc...
base/metrics/histogram.h:198: base::Histogram::kUmaTargetedHistogramFlag))
This should not be UMA-targeted.

[gavinp, 2013-01-08 17:12:41]

Thanks for catching that flag goofup, Ilya.

I found myself a bit sad when I was hacking and used HISTOGRAM_BOOLEAN to find
it didn't exist. I briefly considered doing preprocessor chicanery to declare
them together with the same code, but my saner nature suggested this more humble
CL.

https://codereview.chromium.org/11794020/diff/1/base/metrics/histogram.h
File base/metrics/histogram.h (right):

https://codereview.chromium.org/11794020/diff/1/base/metrics/histogram.h#newc...
base/metrics/histogram.h:198: base::Histogram::kUmaTargetedHistogramFlag))
On 2013/01/07 22:52:23, Ilya Sherman wrote:
> This should not be UMA-targeted.

No kidding. Fixed.

[Ilya Sherman, 2013-01-08 22:05:37]

LGTM, thanks.

[commit-bot: I haz the power, 2013-01-08 22:10:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/11794020/11001

[commit-bot: I haz the power, 2013-01-09 01:47:52]

Change committed as 175658