Issue 11791039: Removes SimpleMenuModel::FlipIndex. It was only used by

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11791039: Removes SimpleMenuModel::FlipIndex. It was only used by (Closed)

Created:
7 years, 11 months ago by sky

Modified:
7 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Removes SimpleMenuModel::FlipIndex. It was only used by SystemMenuModel. I've made it so SystemMenuModel doesn't need it. This is a precursor to sharing system menu building code among the frame types. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175643

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -65 lines)			Patch
M	chrome/browser/ui/views/frame/browser_frame_win.cc	View	3 chunks	+30 lines, -32 lines	0 comments	Download
M	chrome/browser/ui/views/frame/system_menu_model.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/frame/system_menu_model.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/base/models/menu_model.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/models/simple_menu_model.h	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	ui/base/models/simple_menu_model.cc	View	8 chunks	+11 lines, -17 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/11791039/1

7 years, 11 months ago (2013-01-08 21:04:42 UTC) #3

Message was sent while issue was closed.

Change committed as 175643