Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 11791018: When an iframe displays its srcdoc, generate navigation events for about:srcdoc (Closed)

Created:
7 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 11 months ago
Reviewers:
Charlie Reis, marja
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

When an iframe displays its srcdoc, generate navigation events for about:srcdoc BUG=143337 TEST=unit_tests:FrameNavigationStateTest.SrcDoc, browser_tests:WebNavigationApiTest.SrcDoc R=marja@chromium.org,creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175518

Patch Set 1 #

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
7 years, 11 months ago (2013-01-07 13:07:20 UTC) #1
jochen (gone - plz use gerrit)
plz review. This depends on https://chromiumcodereview.appspot.com/11788015/ and https://codereview.chromium.org/11801011/ Marja, can you review all the files, ...
7 years, 11 months ago (2013-01-07 13:09:38 UTC) #2
marja
lgtm
7 years, 11 months ago (2013-01-07 13:54:07 UTC) #3
Charlie Reis
LGTM, with the same question from https://codereview.chromium.org/11788015/.
7 years, 11 months ago (2013-01-07 19:14:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11791018/1
7 years, 11 months ago (2013-01-08 07:39:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11791018/1
7 years, 11 months ago (2013-01-08 08:21:01 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 12:42:04 UTC) #7
Message was sent while issue was closed.
Change committed as 175518

Powered by Google App Engine
This is Rietveld 408576698